Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go server linux installers should not automatically start the Go server service #3119

Closed
vivekprahlad opened this issue Jan 25, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@vivekprahlad
Copy link

commented Jan 25, 2017

Issue Type
  • Feature proposal
Summary

Currently, according to https://github.com/gocd/gocd/blob/master/installers/linux/shared/partials/_after_install_go-server.sh.erb, the Go server is automatically started once it is installed via linux installers.

This is problematic in situations where Go server AMIs or Docker containers are built using the linux installers (automatically starting the server leads to non-deterministic builds, as the server takes a while to do so, and makes a number of changes to the file system as it boots), and this leaves the zip file based install as the only option.

IMHO, it is trivial to explicitly start the service. However, the opposite is not true: it is currently not possible to prevent the service from automatically starting. Interestingly, the go agent installer does not have this behaviour.

Other open source packages (for example, ElasticSearch) used to have this behaviour as well, but have since disabled it. Please see this issue as an example.

@arvindsv

This comment has been minimized.

Copy link
Member

commented Jan 25, 2017

I think @ketan had a thought similar to this. I remember talking about installation vs. upgrade.

@ketan

This comment has been minimized.

Copy link
Member

commented Jan 25, 2017

@vivekprahlad — this has been discussed a number of times before. I will get back to you with something in a couple of days.

PS: Hi!

ketan added a commit to ketan/gocd that referenced this issue Jan 30, 2017

Do not start service on a new install. Allow users to configure the a…
…gent and server and have them start it up. (gocd#3119)
@ketan

This comment has been minimized.

Copy link
Member

commented Jan 30, 2017

@vivekprahlad — could you take a look at #3133 and see if it's in line with what you expect?

@vivekprahlad

This comment has been minimized.

Copy link
Author

commented Jan 31, 2017

@ketan - Thanks, looks good!

ketan added a commit to ketan/gocd that referenced this issue Feb 14, 2017

Do not start service on a new install. Allow users to configure the a…
…gent and server and have them start it up. (gocd#3119)

varshavaradarajan added a commit that referenced this issue Feb 15, 2017

Merge pull request #3133 from ketan/fix/prevent-linux-service-startup
Do not start service on a new install. Allow users to configure the agent and server and have them start it up. (#3119)

@rajiesh rajiesh added this to the Release 17.2 milestone Feb 21, 2017

@rajiesh

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2017

Verified on GoCD version 17.2.0 (4587-442a7d67087844e44a2dcf5824164e1dfe00cc45). In debian and rpm based installers after fresh install the go-server and go-agent do not start automatically. In upgrade scenario the state of the service before upgrade is maintained

@rajiesh rajiesh closed this Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.