New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make job history sidebar be a dropdown #3299
Conversation
* This will free up a fair amount of real estate for the console logs
@naveenbhaskar thoughts? |
yes.. dropdown doesn't have to be so long. it can scroll. we can make the min-height of the left tab and the job history bar the same, so that it will look the same height in most of the scenarios. |
@naveenbhaskar I believe that's what I've got in this PR. Unless I'm misunderstanding you. If I'm not misunderstanding you, then I think this can be merged. |
I think he's saying that in the second image, the dropdown can be smaller. Not sure. Let's see what he says. |
I feel like what @naveenbhaskar is talking about is already in this PR. That said, I could just be confused. Regardless, I think the screenshot I uploaded is a little unclear. So, here's a better one: |
Hi,
what I meant is the height if the left tab and the job history panel can have same height so that it will look good.
|
@naveenbhaskar Does the latest screenshot I posted match up with what you're saying? If so, then I think this can be merged. |
Hi isabelle,
since i am on the ux refresh, didnt get time to get the PR merged in my
local machine and test it. could you please send a fullscreen screenshot so
that i can see it?
thanks
…On Wed, Mar 29, 2017 at 11:16 PM, Isabelle Carter ***@***.***> wrote:
@naveenbhaskar <https://github.com/naveenbhaskar> Does the latest
screenshot I posted match up with what you're saying? If so, then I think
this can be merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3299 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABjXOdfdUIUjYoYLIvLuHOjvgMh5nGyBks5rqpkRgaJpZM4Mlw8i>
.
--
---------------------------------------------------------------------------------------
Thanks and regards
Naveen Bhaskar
Experience Design | User Interface Development
Bangalore
Hangout & Skype : naveenbhaskar.77
Mobile : +
91
.9
632946267
|
@naveenbhaskar I sent them to you on gitter |
Hi Isabelle,
Thank you for the screenshots.. it looks good.
-------------------------------------
Thanks and regards
Naveen Bhaskar
Experience Design | User Interface Development
Bangalore
Hangout & Skype : naveenbhaskar.77
Mobile : +91.9632946267
… On Mar 31, 2017, at 7:09 AM, Isabelle Carter ***@***.***> wrote:
@naveenbhaskar <https://github.com/naveenbhaskar> I sent them to you on gitter
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#3299 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjXOd_ai8gSDX4TEO4hLqVEgdlRbtsjks5rrFlVgaJpZM4Mlw8i>.
|
@ibnc — is this PR ready to merge? Is there anything pending on it? |
@ketan Yep, it's ready to merge |
This PR changes the job history sidebar to be a dropdown instead. This frees up the space it is currently taking up for the console log (257px to be exact). I based the styling of this work off of mock ups provided by @naveenbhaskar. Bellow are screenshots
Console Tab:
Console Tab with job history expanded:
Note: The other tabs don't take up nearly as much vertical real estate as the console tab, and thus sometimes the the content of the job history dropdown will be too long. In this case, the dropdown's content will scroll. See bellow for an example.
Non Console Tab:
Non Console Tab with job history expanded (Note that in this case, the job history dropdown scrolls the overflow):