CCtray lists pipelines for users belonging to plugin role #3954 #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If a 'pluginRole' is authorized to view a pipeline_group, during generating the CcTray cache AllowedViewers for a pipeline would list users of a pluginRole with a active session. Thereby any users for this role who would login after the cache is genrated would not be able to list these pipelines. With this commit, AllowedViewers would have a list of PluginRoleConfigs, which would give an accurate list of users at any given point of time. * Changes to any SecurityAuthConfig(Role And AuthConfig) through the API would now refresh the CCTrayCache.
* If super admins are defined only through a 'role' or 'pluginRole' CCTrayViewAuthority considers it as presence of superAdmins. This would be true even if the configured roles do not have users defined. This is consitent with how dashboard behaves. * CCTrayViewAuthority considers all super admins defined using pluginRole as viewers of pipeline_group. * ViewAuthority for users belonging to pluginRole was cached earlier, with this commit it is resloved during access of ccTray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generating the CcTray cache AllowedViewers for a pipeline would list
users of a pluginRole with a active session. Thereby any users for
this role who would login after the cache is generated would not be
able to list these pipelines. With this commit, AllowedViewers would
have a list of PluginRoleConfigs, which would give an accurate list of
users at any given point of time.
would now refresh the CCTrayCache.
it as presence of superAdmins. This would be true even if the configured roles do not have users
defined. This is consitent with how dashboard behaves.
pluginRole as viewers of pipeline_group.
with this commit it is resloved during access of ccTray.