Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO_SERVER_PORT environment variable is not honored #3982

Closed
EbenZhang opened this issue Nov 6, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@EbenZhang
Copy link

commented Nov 6, 2017

Issue Type
  • Bug Report
Summary

After upgraded to v17.11.0, GO_SERVER_PORT environment variable is not honored.

Environment
Basic environment details

Go Server Version: | 17.11.0 (5520-9f6909e2f64b07d2dce5cecd4ea5b92b8e19d6b1)
JVM version: | 1.8.0_102
OS Information: | Windows 10 10.0
Usable space in artifacts repository: | 503 GB
Database schema version: | 1708001
GOCD Service command line: E:\GoServer\cruisewrapper.exe -s E:\GoServer\config\wrapper-server.conf

Additional Environment Details

See attached: goenv.txt

Steps to Reproduce
  • Make sure port 80 is not occupied
  • Make sure the logon user for GOCD Server Service has the admin permission
  • Start the GOCD service
Expected Results

The server is listening on port 80

Actual Results

The server is listening on port 8153

Any other info

It was working well before I upgraded it to v17.11.0

@akshaydewan

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2017

Hi @EbenZhang, which version of Go Server were you using before upgrading to v17.11.0?

Looking at the code, I think that this was never implemented in the windows service, but worked only with the .bat file.

@varshavaradarajan

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2017

Closing as 17.12.0 was released.

@EbenZhang

This comment has been minimized.

Copy link
Author

commented Jan 20, 2018

Upgraded the 17.11 instance to 17.12.0 (5626-cb7df2ffe421e43f2a682a7a323cb3a3e30734cc). It still doesn't work.

@ketan

This comment has been minimized.

Copy link
Member

commented Jan 20, 2018

In 17.12.0 We've changed how port numbers assignment works on windows:

Please edit the file config/wrapper-properties.conf in the server install directory and add the following to override the defaults:

wrapper.java.additional.9=-Dcruise.server.port=8153
wrapper.java.additional.10=-Dcruise.server.ssl.port=8154
@EbenZhang

This comment has been minimized.

Copy link
Author

commented Jan 20, 2018

it works with the configuration in the wrapper-properties.conf. Thanks.

@EbenZhang

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

@ketan every time after upgraded, the config file gets overwritten to default port. Is there a way to keep the port settings?

@ketan

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

@EbenZhang — can you confirm what file you've edited again. You're supposed to edit the file config/wrapper-properties.conf and it is not supposed to be overwritten — since it's not packaged with the gocd server installer. Editing the wrapper-server.conf will be cause the file to be overwritten on an upgrade.

@EbenZhang

This comment has been minimized.

Copy link
Author

commented Aug 25, 2018

ya, I changed the setting in wrapper-server.conf. The wrapper-properties.conf works fine. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.