Use tooltips everywhere

[oxinabox]

Issue Type

• Feature enhancement

Summary

Tool tips are great.
We should have more of them.
They greatly enhance the understand-ability of icons.

Environment

Basic environment details

• Go Version: 17.12.0 (5626-cb7df2ffe4…682a7a323cb3a3e30734cc)
• JAVA Version: 1.8.0_151
• OS: Linux 4.10.0-42-generic
• Browser vendor and version: Vivaldi | 1.13.1008.40 (32-bit) and Google Chrome Version 63.0.3239.84 (64-bit)

Steps to Reproduce

Mouse over an icon.
Notice its lack of tool-tip.
Optional: Be confused as to what it does.

Expected Results

Almost all icons should have tool tips

Actual Results

Many icons do not have tool tips.

Possible Fix

add title attribute to elements to give them tool tips.
This may or may not improve accessibility for screen readers -- but that is just a side benefit.

Some icons that could do with tool tips

A probably incomplete list.

• /pipelines
  edit pipeline
• /admin/security/auth_config
  edit config, duplicate, delete

[ankitsri11]

Pointing out few more icons where tooltip would be useful.

GoCD version - 18.6

Pipeline trigger, trigger with options and pause button.

Edit pipeline group

Cancel/ re-run stage

[alan-ghelardi]

Besides adding titles some buttons should be properly labeled with aria-label property. When browsing with the tab key screen readers read those tooltips, but when navigating with arrow keys (what blind users do very often - I'm a blind engineer) they don't read them at all. From the accessibility perspective, providing correct labels (either via aria-label or hidden span elements) is more important than titles. For example, currently when I'm reading a pipeline in the dashboard I can't understand, at a first moment, which was the result of the last execution of its stages. I need to tab through the stages to "force" the screen reader to read the titles that contain the stage name and its state, what is very tedious. If there were labels for those buttons I would be able to get those information faster.

[alan-ghelardi]

Just a small complement: what I said above is particularly true for links; for traditional buttons (the HTML tag button) when there is a title but not a text, the screen reader always interprets the title as the button label regardless the navigation mode.

[arvindsv]

Moved to 18.7 milestone - but it might not happen in 18.7. Might get pushed one release. We should work with @alan-ghelardi and get feedback as it is being worked on.

[maheshp]

Fixed as part of #5046

[rajiesh]

Tool tips added as part of #5046 . More things can be done to improve application accessibility which will be tracked with separate issues

[adityasood]

@alan-ghelardi we have made some accessibility improvements as part of our latest release v18.8.0.

[ketan]

For anyone reading this: This issue is closed not to say that we've 'fixed' usability everywhere, but to say that for specific places identified in this issue. If there are specific pages and places within GoCD which are missing tooltips, a new issue should be opened and someone can help address it.

Thanks

[alan-ghelardi]

@adityasood awesome. Thank so much for the update. I'll have a look at the improvements.