Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate roles assigned to stage authorization on template update through API #4176

Closed
maheshp opened this issue Jan 12, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@maheshp
Copy link
Member

commented Jan 12, 2018

Issue Type
  • Bug Report
Summary

Template update through API does not validate presence of a role. Thereby a non-existent role can be added to the template.

This leads to validation errors while saving the template from UI or updating the config-xml. Since the config_xml has errors a server restart would fail as well.

varshavaradarajan added a commit to varshavaradarajan/gocd that referenced this issue Jan 15, 2018

varshavaradarajan added a commit to varshavaradarajan/gocd that referenced this issue Jan 16, 2018

varshavaradarajan added a commit to varshavaradarajan/gocd that referenced this issue Jan 17, 2018

maheshp added a commit that referenced this issue Jan 18, 2018

Merge pull request #4185 from varshavaradarajan/stage-approval-valida…
…tion

Validate the users and roles defined in stage authorization in the context of the pipeline using the template. (#4176)

@rajiesh rajiesh added this to the Release 18.1 milestone Jan 19, 2018

@rajiesh

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2018

Verified on 18.1.0 (5932-46938d88757632f7c20e899e682181862bf4296b)

@rajiesh rajiesh closed this Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.