Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Dashboard] Pipeline with lock behavior specified continues to be locked after run completion #4448

Closed
rajiesh opened this issue Feb 28, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@rajiesh
Copy link
Contributor

commented Feb 28, 2018

Issue Type
  • Bug Report
Summary

Pipeline with lock behavior specified continues to be locked after run completion. A full cache regeneration only removes the invalid data ie., do a full config save and then visit dashboard page the lock is removed

Environment
Basic environment details
  • Go Version: 18.2.0 (6175-1058e75b18e8a645dd71702851994a010789f450)
Additional Environment Details
Steps to Reproduce
  1. Create a pipeline with lock behavior set(either lockOnFailure or unlockWhenFinished)
  2. Trigger the pipeline and wait for it to complete
  3. Visit the new dashboard page - Pipeline is still locked and trigger options disabled
  4. Do a full config save
  5. Now on new dashboard page pipeline lock is released
Expected Results

Pipeline lock should be released as per the lock behavior set

Actual Results

Pipeline continues to be locked even after completion

@rajiesh rajiesh added the Dashboard label Feb 28, 2018

@rajiesh rajiesh added this to the Release 18.2 milestone Feb 28, 2018

@rajiesh rajiesh modified the milestones: Release 18.2, Release 18.3 Mar 8, 2018

akshaydewan added a commit to akshaydewan/gocd that referenced this issue Mar 9, 2018

Notify listeners about lock status change only after the transaction …
…is complete (gocd#4448)

Since the DB cache is invalidated in the afterCommit hook, it was possible for the event listeners to get stale information. With this change the lock status event listeners will get notified only after the transaction has completed.

akshaydewan added a commit to akshaydewan/gocd that referenced this issue Mar 9, 2018

Notify listeners about lock status change only after the transaction …
…is complete (gocd#4448)

Since the DB cache is invalidated in the afterCommit hook, it was possible for the event listeners to get stale information. With this change the lock status event listeners will get notified only after the transaction has completed.

akshaydewan added a commit to akshaydewan/gocd that referenced this issue Mar 12, 2018

Notify listeners about lock status change only after the transaction …
…is complete (gocd#4448)

Since the DB cache is invalidated in the afterCommit hook, it was possible for the event listeners to get stale information. With this change the lock status event listeners will get notified only after the transaction has completed.

akshaydewan added a commit to akshaydewan/gocd that referenced this issue Mar 16, 2018

Notify listeners about lock status change only after the transaction …
…is complete (gocd#4448)

Since the DB cache is invalidated in the afterCommit hook, it was possible for the event listeners to get stale information. With this change the lock status event listeners will get notified only after the transaction has completed.

akshaydewan added a commit to akshaydewan/gocd that referenced this issue Mar 20, 2018

Notify listeners about lock status change only after the transaction …
…is complete (gocd#4448)

Since the DB cache is invalidated in the afterCommit hook, it was possible for the event listeners to get stale information. With this change the lock status event listeners will get notified only after the transaction has completed.

akshaydewan added a commit to akshaydewan/gocd that referenced this issue Mar 20, 2018

Notify listeners about lock status change only after the transaction …
…is complete (gocd#4448)

Since the DB cache is invalidated in the afterCommit hook, it was possible for the event listeners to get stale information. With this change the lock status event listeners will get notified only after the transaction has completed.

akshaydewan added a commit to akshaydewan/gocd that referenced this issue Mar 20, 2018

Notify listeners about lock status change only after the transaction …
…is complete (gocd#4448)

Since the DB cache is invalidated in the afterCommit hook, it was possible for the event listeners to get stale information. With this change the lock status event listeners will get notified only after the transaction has completed.

akshaydewan added a commit to akshaydewan/gocd that referenced this issue Mar 22, 2018

Notify listeners about lock status change only after the transaction …
…is complete (gocd#4448)

Since the DB cache is invalidated in the afterCommit hook, it was possible for the event listeners to get stale information. With this change the lock status event listeners will get notified only after the transaction has completed.

jyotisingh added a commit that referenced this issue Mar 27, 2018

Merge pull request #4507 from akshaydewan/issue-4448
Notify listeners about lock status change only after the transaction is complete (#4448)
@rajiesh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2018

Verified on 18.3.0 (6530-f9dc89e397d1b134f4d124e6381f8764e38e0a1d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.