Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoCD server sends notifications to disabled users #5277

Closed
adityasood opened this issue Oct 17, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@adityasood
Copy link
Contributor

commented Oct 17, 2018

Issue Type
  • Bug Report
Summary

If a user is disabled within GoCD, the server still sends notifications based on user preferences. Disabled users should not get email notifications.

Basic environment details
  • Go Version: 18.10.0-7703
  • JAVA Version: Java10
  • OS: MacOs
  • Browser vendor and version (if relevant): Chrome
Steps to Reproduce
  1. Create a user "emailUser" within GoCD using an authentication plugin
  2. Login as emailUser and set preferences to receive notifications for a pipeline run
  3. Login as GoCD server admin and disable the emailUser from Admin -> User Summary
  4. Trigger the pipeline for which emailUser subscribed for.
  5. You will receive email notifications for the disabled emailUser
Expected Results

The server should check for disabled users before sending notifications

Actual Results

The server today sends notifications to all subscribed users

@bdpiparva bdpiparva added this to the Release 18.11 milestone Oct 17, 2018

@bdpiparva

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2018

This is a bug with GoCD server. The server always sends a notification to all the users having notification enabled.

bdpiparva added a commit to bdpiparva/gocd that referenced this issue Oct 17, 2018

bdpiparva added a commit to bdpiparva/gocd that referenced this issue Oct 17, 2018

bdpiparva added a commit to bdpiparva/gocd that referenced this issue Oct 17, 2018

@bdpiparva bdpiparva added the bug label Oct 17, 2018

bdpiparva added a commit to bdpiparva/gocd that referenced this issue Oct 17, 2018

bdpiparva added a commit that referenced this issue Oct 17, 2018

@adityasood

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

Fixed by #5279

@adityasood

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

verified on 18.11.0 (7724-49d741308cbbb499554e4e2843f0812e2e9b8460).

@adityasood adityasood closed this Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.