Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline pause message is not shown completely on dashboard #6640

Open
GaneshSPatil opened this issue Jul 17, 2019 · 5 comments · Fixed by #6698

Comments

@GaneshSPatil
Copy link
Contributor

commented Jul 17, 2019

Issue Type
  • Bug Report
Summary

Pipeline pause message is stripped on the dashboard.

Actual Result

Screen Shot 2019-07-17 at 3 49 21 PM

Expected Result

Screen Shot 2019-07-17 at 3 56 36 PM

Possible Fix

Remove truncate-to-lines($line-count: 3); line and add font-size: 12px; instead.

So the final .pipeline_pause-message class CSS looks like:

.pipeline_pause-message {
  font-size: 12px;
  margin:    5px 0 0 0;
  float:     left;
  clear:     both;
}
@ketan

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Or maybe show a tooltip? Do we have a limit on how long the DB column is?

@GaneshSPatil

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

The pause_cause has a DB limit of 255 characters.

I feel 255 characters can be shown easily on the pipeline box.
Here is a screenshot with 255 character long pause message.

Screen Shot 2019-07-17 at 4 10 20 PM

Or maybe show a tooltip?

As a user, I would like to know the entire pause message upfront. A tooltip will cause another (unnecessary) user interaction?

@GaneshSPatil

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

This was closed by automation.
Reopening for testing..

@GaneshSPatil GaneshSPatil reopened this Aug 19, 2019

@rajiesh

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

@GaneshSPatil @SnehaPL While dashboard is shows 255 char long pause message clearly, pipeline history page needs to be fixed for such large messages

Screen Shot 2019-08-21 at 2 25 33 PM

@maheshp maheshp added this to To do in 19.8.0 Aug 21, 2019

@SnehaPL

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Ok, I'll send separate PR to fix this

@maheshp maheshp moved this from To do to Done in 19.8.0 Sep 5, 2019

@rajiesh rajiesh modified the milestones: Release 19.8.0, Release 19.9.0 Sep 5, 2019

@rajiesh rajiesh removed this from Done in 19.8.0 Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.