Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environments Get API does not honor If-None-Match header #6682

Closed
SnehaPL opened this issue Jul 26, 2019 · 2 comments

Comments

@SnehaPL
Copy link
Contributor

commented Jul 26, 2019

Issue Type
  • Bug Report
Summary

Environments Get API should return 304 (Not Modified) when appropriate If-None-Match header is specified.

Basic environment details
  • Go Version: 19.7.0 (9552-aa833fbf095e66489c765751dfa23daa741c35b4)
  • JAVA Version: 1.8.0_211
  • OS: Mac OS X 10.14.6
Expected Results

Environments Get API should return 304 (Not Modified) when appropriate If-None-Match header is specified.

Actual Results

Environments Get API return 200 (Ok) when appropriate If-None-Match header is specified.

@GaneshSPatil

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Fixed as part of #6683

@GaneshSPatil GaneshSPatil added this to the Release 19.8.0 milestone Aug 14, 2019

@GaneshSPatil GaneshSPatil referenced this issue Aug 14, 2019
64 of 74 tasks complete
kritika-singh3 added a commit to vrushaliwaykole/gocd that referenced this issue Aug 16, 2019
kritika-singh3 added a commit to vrushaliwaykole/gocd that referenced this issue Aug 16, 2019
kritika-singh3 added a commit to vrushaliwaykole/gocd that referenced this issue Aug 19, 2019

@maheshp maheshp added this to Done in 19.8.0 Aug 20, 2019

@rajiesh

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Verified on 19.8.0 (9746-6bbad2a99f2a38bfc31210777c22d9bfda941e68)

@rajiesh rajiesh closed this Aug 21, 2019

@rajiesh rajiesh moved this from Done to QA Done in 19.8.0 Aug 21, 2019

kritika-singh3 added a commit to vrushaliwaykole/gocd that referenced this issue Sep 5, 2019
kritika-singh3 added a commit to vrushaliwaykole/gocd that referenced this issue Sep 9, 2019
kritika-singh3 added a commit to vrushaliwaykole/gocd that referenced this issue Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.