Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User info synchronisation with external sources #6832

Closed
kritika-singh3 opened this issue Aug 28, 2019 · 2 comments

Comments

@kritika-singh3
Copy link
Contributor

commented Aug 28, 2019

Parent Issue: gocd-contrib/github-oauth-authorization-plugin#69

Issue Type
  • Feature enhancement
Summary

Any GoCD user information is not updated with the actual source after the first login.
E.g. if the email associated with the github profile is updated, the same is never reflected in the GoCD until that user is deleted and added again.

Suggestion

After successful authentication, the user info received should be compared with the info stored in the DB. In case of any update, the DB should be updated to reflect the same.

@bdpiparva bdpiparva added this to the Release 19.8.0 milestone Aug 28, 2019

@bdpiparva bdpiparva added the users label Aug 28, 2019

kritika-singh3 added a commit to kritika-singh3/gocd that referenced this issue Aug 28, 2019
Fixes: gocd#6832
 - On Successful Authentication of any user in GoCD, we originally use to add the user if it does not exist.
   Updated this flow and added additional check for change in either display name or email. If either of them have changed, we will update the DB entry to reflect the same
@kritika-singh3

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Closed via automation. Reopening for testing.

@maheshp maheshp added this to Done in 19.8.0 Aug 28, 2019

@rajiesh

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Verified on 19.8.0 (9912-33898b3adaf72cedea1604882d3554fd586571a8)

@rajiesh rajiesh closed this Sep 5, 2019

@rajiesh rajiesh moved this from Done to QA Done in 19.8.0 Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.