Could not find file config/cipher and config/go.feature.toggles

[belka-ew]

Issue Type

• Bug Report

Summary

Every minute I get the same 2 messages in the go-server logs:

2020-12-25 10:45:47,179 WARN  [pool-2-thread-1] GoFilesStatusProvider:79 - Could not find file /home/belka/Downloads/go-server-20.10.0/config/go.feature.toggles
2020-12-25 10:45:47,179 WARN  [pool-2-thread-1] GoFilesStatusProvider:79 - Could not find file /home/belka/Downloads/go-server-20.10.0/config/cipher

I was able to fix the first one by creating config/go.feature.toggles:

{
  "version": "1",
  "toggles": []
}

I'm not sure it is the expected solution, the format doesn't seem to be documented anywhere; I found this in other issues.

As far as I understand config/cipher is an old file replaced by config/cipher.aes.

This makes logs not that useful since these are polluted with the same messages,

Environment

Basic environment details

• Go Version: 20.10.0 (12356-b16b6bc3f…465ff2168d1cc66c95b4d5)
• JAVA Version: 11.0.8
• OS: Linux 4.19.163

Additional Environment Details

Steps to Reproduce

1. Unzip go-server-20.10.0-12356.zip
2. Go into go-server-20.10.0 and start the server ./bin/go-server console
3. Wait 5 minutes
4. Look into logs/go-server.log, every minute the same messages are appended to the logs:

2020-12-25 10:45:47,179 WARN  [pool-2-thread-1] GoFilesStatusProvider:79 - Could not find file /home/belka/Downloads/go-server-20.10.0/config/go.feature.toggles
2020-12-25 10:45:47,179 WARN  [pool-2-thread-1] GoFilesStatusProvider:79 - Could not find file /home/belka/Downloads/go-server-20.10.0/config/cipher

Expected Results

The warning about the missing files is logged once, not every minute.

Actual Results

Logs are full with the same warning.

Possible Fix

• Missing config/cipher is probably an info message, not a warning, if config/cipher isn't supposed to exist in the new installations.
• config/go.feature.toggles can be provided with the go-server packages.

Log snippets

2020-12-25 10:45:47,179 WARN  [pool-2-thread-1] GoFilesStatusProvider:79 - Could not find file /home/belka/Downloads/go-server-20.10.0/config/go.feature.toggles
2020-12-25 10:45:47,179 WARN  [pool-2-thread-1] GoFilesStatusProvider:79 - Could not find file /home/belka/Downloads/go-server-20.10.0/config/cipher