Minor improvements to agent launcher logging redirection #11295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the very confusing duplicate dates in agent logs piped from the agent to the launcher. When there is slowness or buffering within the launcher thread, these could log very different times which was totally confusing. Since the agent logs are already full logback timestamped logs, prefixing again didn't seem necessary. Additionally, the logging has 100ms pauses between piping, which meant the timestamps are always going to be misleading as to when the actual log event occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misleading duplicate timestamps in logs that originate in the agent process, but are logged from the agent launcher, especially when redirecting to console.