Make JRE dependencies from packages optional/recommended#12792
Merged
chadlwilson merged 1 commit intogocd:masterfrom May 24, 2024
Merged
Make JRE dependencies from packages optional/recommended#12792chadlwilson merged 1 commit intogocd:masterfrom
chadlwilson merged 1 commit intogocd:masterfrom
Conversation
chadlwilson
force-pushed
the
optional-package-deps
branch
4 times, most recently
from
1496bce to
9bb912b
Compare
Change them to recommended dependencies in each ecosystem; and fallback to just using `java` off path from the configuration if not available.
chadlwilson
force-pushed
the
optional-package-deps
branch
from
9bb912b to
231d679
Compare
Member
Author
|
Hiya @matthiaskraaz - WDYT about changing these to recommended/weak dependencies? There's a (mild) complaint in #12791 and I did another deep dive into virtual packages, but I really can't find a good solution for the "general case" of finding the install location of an arbitrary package that satisfies a virtual package dependency, although do have a hack at https://github.com/chadlwilson/gocd/compare/231d6795c42a9dfd80a22b1540a2586af05bf289...chadlwilson:hard-virtual-package-dep?expand=1 which doesn't really even "try" to find the proper install location unless it's one of the openjdk variants satisfying the hard virtual package dependency. I'm not sure :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12791
Change them to recommended dependencies in each ecosystem; and fallback to just using
javaoff path from the configuration if not available.