Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up#695 Fixing admin email length to fit RFC 3696, Errata 1003 #2269
Conversation
arvindsv
merged commit 520cb05
into
gocd:master
Jun 6, 2016
arvindsv
referenced this pull request
Jun 6, 2016
Merged
'From' field fix - #695 Fixing admin email length to fit RFC 3696, Er… #2271
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Would we not "fix" this in the XSD as well? |
pushed a commit
to tedops/gocd
that referenced
this pull request
Jun 7, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tedops
Jun 7, 2016
Hey @ketan - that's a good callout, and as I was submitting a PR to add that, I noticed @arvindsv already had one cooking.
The cruise-config.xsd didn't previously have any length restriction defined for emailType, which is why this PR was originally only to change the Ruby template. However, I do agree that being explicit is better than implicit, and therefore support Aravind's above linked PR.
tedops
commented
Jun 7, 2016
|
Hey @ketan - that's a good callout, and as I was submitting a PR to add that, I noticed @arvindsv already had one cooking. The |
tedops commentedJun 6, 2016
According to the IETF, RFC 3696 in Errata 1003 states that email address lengths are to be 254 octets. This is a fix to both follow that standard and fix the root of issue #695.