Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds whitelists #2314

Merged
merged 14 commits into from Jun 17, 2016

Conversation

Projects
None yet
4 participants
@cv
Copy link
Contributor

commented Jun 17, 2016

This is a continuation of #2144 - please refer to it for more notes and in-depth discussion.

I've merged the commits from @ravenscar and will work on fixing the necessary tests so this can be merged in for the next available release.

ravenscar and others added some commits Apr 24, 2016

ScmMaterialConfig now takes an invertFilter parameter
Subclasses of ScmMaterialConfig now accept invertFilter and an argument after filter in their maximal constructors
Subclasses of ScmMaterial now set invertFilter in their *MaterialConfig constructor.
Subclasses of ScmMaterial now send the invertFilter value when config() is called
Fixed tests of *MaterialConfig maximal constructors to pass false for invertFilter
Fix signature of ctors.
Seems like this was missed by an automated refactoring.
@arvindsv

This comment has been minimized.

Copy link
Member

commented Jun 17, 2016

Sorry. Ran a PR build for this, by mistake. I see it has run and everything is fine.

arvindsv added a commit to arvindsv/gocd that referenced this pull request Jun 17, 2016

@arvindsv arvindsv merged commit aae7012 into gocd:master Jun 17, 2016

7 of 8 checks passed

create-maven-release-PR/create-maven-release
Details
build-linux-PR/build-non-server
Details
build-linux-PR/build-server
Details
build-linux-PR/check_tlb_correctness
Details
build-linux-PR/go-sdk
Details
build-windows-PR/build-non-server-windows
Details
build-windows-PR/build-server-windows
Details
qa-packages-PR/dist
Details

arvindsv added a commit that referenced this pull request Jun 17, 2016

@ketan

This comment has been minimized.

Copy link
Member

commented Jun 17, 2016

@cv could you update the config reference doc too?

https://docs.go.cd/current/configuration/configuration_reference.html

@cv cv deleted the cv:whitelists branch Jun 17, 2016

cv added a commit to cv/docs.go.cd that referenced this pull request Jun 17, 2016

Documents `invertFilter`
This feature was added by gocd/gocd#2314

@cv cv referenced this pull request Jun 17, 2016

Merged

Documents `invertFilter` #35

iamsumanth added a commit to iamsumanth/gocd that referenced this pull request Jun 28, 2016

@ketan ketan added this to the Release 16.6 milestone Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.