Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze/Disable Edits on pipeline config page until the save finishes #3266

Merged
merged 4 commits into from Mar 16, 2017

Conversation

Projects
None yet
4 participants
@GaneshSPatil
Copy link
Contributor

commented Mar 15, 2017

screen shot 2017-03-15 at 12 14 13 pm

for background blur, we have used -webkit-filter which is supported on these browsers.

@naveenbhaskar -- can you review the css changes?

@GaneshSPatil GaneshSPatil self-assigned this Mar 15, 2017

@GaneshSPatil GaneshSPatil requested a review from naveenbhaskar Mar 15, 2017

@zabil zabil added the in progress label Mar 15, 2017

@@ -176,7 +177,7 @@ const PipelineConfigWidget = function (options) {
return (
<form class='pipeline'>
{header()}
<f.row class='pipeline-body'>
<f.row class={`pipeline-body ${ vnode.state.vm.pageSaveState()}`}>

This comment has been minimized.

Copy link
@ketan

ketan Mar 15, 2017

Member

too much whitespace?

@@ -83,6 +83,26 @@ describe("PipelineConfigWidget", () => {
expect($root.find('.pipeline .heading h1')).toHaveText('Pipeline configuation for pipeline yourproject');
});

it('should disable button and page edits while pipeline config save is in progress', () => {
jasmine.Ajax.install();

This comment has been minimized.

Copy link
@ketan

ketan Mar 15, 2017

Member

Use block form using jasmine.Ajax.withAjax()

@GaneshSPatil GaneshSPatil force-pushed the GaneshSPatil:freeze-pipeline-config-page branch from 6ac41d8 to d7fb376 Mar 15, 2017

GaneshSPatil added some commits Mar 15, 2017

@GaneshSPatil GaneshSPatil force-pushed the GaneshSPatil:freeze-pipeline-config-page branch from d7fb376 to a9851bd Mar 16, 2017

@GaneshSPatil

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2017

@ketan -- blurred using opacity
screen shot 2017-03-16 at 10 19 34 am
`

@ketan ketan added this to the Release 17.3 milestone Mar 16, 2017

@ketan ketan merged commit 262c107 into gocd:master Mar 16, 2017

@ketan ketan removed the in progress label Mar 16, 2017

@GaneshSPatil GaneshSPatil deleted the GaneshSPatil:freeze-pipeline-config-page branch Mar 16, 2017

@jyotisingh jyotisingh added this to the Release 17.3 milestone Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.