Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show cancelled by on the dashboard on hovering over a stage. #5683

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
2 participants
@varshavaradarajan
Copy link
Contributor

commented Jan 9, 2019

@GaneshSPatil - we had spoken about showing the cancelled by information instead of triggered by on the pipeline. I thought that the title on hover where we show the stage status was more appropriate. Let me know what you and @naveenbhaskar think.

screen shot 2019-01-08 at 10 26 35 pm

@varshavaradarajan varshavaradarajan added this to the Release 19.1.0 milestone Jan 9, 2019

@varshavaradarajan varshavaradarajan requested a review from GaneshSPatil Jan 9, 2019

@GaneshSPatil

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

I am OK with showing this information on hover of a cancelled stage. Initially, it used to say up42_stage cancelled. Not it will say up42_stage cancelled by Bob.

\cc: @naveenbhaskar @maheshp

@varshavaradarajan varshavaradarajan force-pushed the varshavaradarajan:dashboard-ui branch from f4a1221 to a55f209 Jan 9, 2019

@GaneshSPatil GaneshSPatil merged commit 792ae61 into gocd:master Jan 10, 2019

8 checks passed

build-linux-PR/build-non-server
Details
build-linux-PR/build-server
Details
build-windows-PR/build-non-server
Details
build-windows-PR/build-server
Details
installers-PR/dist
Details
license/cla Contributor License Agreement is signed.
Details
plugins-PR/build
Details
trigger/do-nothing
Details

@maheshp maheshp added this to In progress in 19.1.0 via automation Jan 10, 2019

@maheshp maheshp moved this from In progress to Done in 19.1.0 Jan 10, 2019

@@ -70,6 +70,10 @@ export default class {
}
}

static showDashboardPath(): string {
return "/go/api/dashboard";

This comment has been minimized.

Copy link
@GaneshSPatil

GaneshSPatil Jan 11, 2019

Contributor

@varshavaradarajan -- This should accept a view name and pass it along as a query param.

This comment has been minimized.

Copy link
@varshavaradarajan

varshavaradarajan Jan 11, 2019

Author Contributor

Oh okay. Will fix it. Sorry, didn't check with the PR run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.