Adding Server version information in v2 ServerInfoProcessor #5686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketan
reviewed
Jan 9, 2019
|
|
||
| MessageHandlerForServerInfoRequestProcessor2_0 processor = new MessageHandlerForServerInfoRequestProcessor2_0(); | ||
|
|
||
| assertThat(processor.serverInfoToJSON(serverConfig), |
Member
There was a problem hiding this comment.
Use assertThatJson instead of matching JSON strings. There's no guarantee of ordering of the different keys in JSON. This is likely to cause flaky tests.
Contributor
Author
There was a problem hiding this comment.
@ketan assertThatJson expects a json object. but the return type here is String. We could otherwise use JSONAssert.assertEquals.
SanjanaB-zz
force-pushed
the
master
branch
2 times, most recently
from
2a7edd0 to
ffb7d67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue aims to expose Go Server version information to the api consumers.
Fixes GoCD api changes required to address the issue