Skip to content

Environments api should accept both encrypted_value and value #5967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vishaldevgire merged 8 commits into from
Apr 3, 2019
Merged

Environments api should accept both encrypted_value and value #5967

vishaldevgire merged 8 commits into from
Apr 3, 2019

Conversation

@vishaldevgire
Copy link
Contributor

@vishaldevgire vishaldevgire commented Mar 11, 2019

  • Allow create/update/patch APIs to accept both encrypted_value and value in JSON request
  • Added a validation to check for existence of either encrypted_value or value
  • While serializing errors in environment variable configuration are rendered

@vishaldevgire vishaldevgire requested a review from bdpiprava March 11, 2019 10:59
@vishaldevgire vishaldevgire force-pushed the environments_api_should_accept_encrypted_value branch from 14d8296 to e9fe6e3 Compare March 12, 2019 06:19
@vishaldevgire vishaldevgire requested a review from bdpiprava March 12, 2019 06:22
@varshavaradarajan varshavaradarajan mentioned this pull request Mar 12, 2019
Closed
@vishaldevgire vishaldevgire force-pushed the environments_api_should_accept_encrypted_value branch from e9fe6e3 to b3a8b4d Compare March 14, 2019 08:57
@maheshp
Copy link
Contributor

maheshp commented Mar 18, 2019

Fixes #5956

@maheshp maheshp added this to the Release 19.3.0 milestone Mar 18, 2019
@vishaldevgire vishaldevgire force-pushed the environments_api_should_accept_encrypted_value branch from b3a8b4d to e02bb12 Compare March 19, 2019 10:45
@vishaldevgire vishaldevgire force-pushed the environments_api_should_accept_encrypted_value branch 5 times, most recently from 1cd47fb to 4209ee0 Compare March 25, 2019 10:43
@vishaldevgire vishaldevgire force-pushed the environments_api_should_accept_encrypted_value branch from 25e1f6c to be255ff Compare March 25, 2019 12:54
@vishaldevgire vishaldevgire force-pushed the environments_api_should_accept_encrypted_value branch from be255ff to 99be635 Compare April 2, 2019 10:42
@vishaldevgire vishaldevgire force-pushed the environments_api_should_accept_encrypted_value branch from a45bb83 to f815ef0 Compare April 3, 2019 04:26
@vishaldevgire vishaldevgire merged commit e6a729d into gocd:master Apr 3, 2019
@GaneshSPatil GaneshSPatil mentioned this pull request Apr 3, 2019
Closed
2 tasks
rajiesh added a commit to rajiesh/ruby-functional-tests that referenced this pull request Apr 8, 2019
@rajiesh
Update environment API spec to include the validation for encrypted v…
0d5a1c5 
…alue

The issue related to it is fixed by this PR - gocd/gocd#5967
@rajiesh rajiesh mentioned this pull request Apr 8, 2019
Merged
@GaneshSPatil GaneshSPatil mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@varshavaradarajan varshavaradarajan varshavaradarajan left review comments

@GaneshSPatil GaneshSPatil GaneshSPatil left review comments

@bdpiprava bdpiprava bdpiprava approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

apis environments

Projects

None yet

Milestone

Release 19.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vishaldevgire @maheshp @varshavaradarajan @bdpiprava @GaneshSPatil