Improvements to the user management page#6036
Merged
vrushaliwaykole merged 6 commits intogocd:masterfrom Apr 11, 2019
Merged
Conversation
Contributor
naveenbhaskar
commented
Mar 28, 2019
naveenbhaskar
commented
- sticky action panel for user table while scrolling
- focus to the flash messages after an action
- confirmation dialog box for delete user action.
1. Added a confirmation modal for delete users 2. Moved the page level message inside users widget as the action header is now stick on the page top 3. Updated the delete success message to contain the login names of users deleted.
naveenbhaskar
force-pushed
the
user_management
branch
from
9f9606b to
09f829b
Compare
Member
|
@naveenbhaskar Can you add an image or an animated gif to show this? |
Contributor
Author
|
|
| private static getMessage(usersToBeDeleted: string[]) { | ||
| return (<div> | ||
| <p>Are you sure you want to delete these users: | ||
| <span className={styles.deletedUsers}> |
Contributor
There was a problem hiding this comment.
Can we rename style as they are not deleted users but users to be deleted?
kritika-singh3
force-pushed
the
user_management
branch
from
829d4ca to
1d6c866
Compare
Contributor
|
@naveenbhaskar @kritika-singh3 the header with |
Contributor
|
@kritika-singh3 @naveenbhaskar while deleting a non-disabled user, I think the delete pop-up does not make sense. We should directly let the user know that the user can not be deleted before being disabled. WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.