Do not extend pluginProfileService for elasticProfileService#6245
Merged
GaneshSPatil merged 2 commits intogocd:masterfrom May 7, 2019
Merged
Conversation
GaneshSPatil
force-pushed
the
remove-plugin-service-from-elastic-agent-service
branch
from
ccad521 to
676dcaa
Compare
* PluginProfileService requires pluginId to be present on the operating entity. As pluginId will be removed from the elastic-agent-profile, elasticAgentService can not extend pluginProfileService. * This refactoring is required for the removal of pluginId from elastic agent profile.
GaneshSPatil
force-pushed
the
remove-plugin-service-from-elastic-agent-service
branch
from
676dcaa to
d68d71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginProfileService requires pluginId to be present on the operating
entity. As pluginId will be removed from the elastic-agent-profile,
elasticAgentService can not extend pluginProfileService.
This refactoring is required for the removal of pluginId from
elastic agent profile.