New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new pipeline create flow should check for group admin as well #6404
The new pipeline create flow should check for group admin as well #6404
Conversation
@@ -45,7 +45,7 @@ public String controllerBasePath() { | |||
@Override | |||
public void setupRoutes() { | |||
path(controllerBasePath(), () -> { | |||
before("", authenticationHelper::checkAdminUserAnd403); | |||
before("", authenticationHelper::checkAdminUserOrGroupAdminUserAnd403); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No tests for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the tests are there now in spark/spark-spa/src/test/groovy/com/thoughtworks/go/spark/spa/PipelinesControllerTest.groovy
:
@Nested
class Security implements SecurityTestTrait, GroupAdminUserSecurity { ... }
Related issue: #6475 |
@@ -45,7 +45,7 @@ public String controllerBasePath() { | |||
@Override | |||
public void setupRoutes() { | |||
path(controllerBasePath(), () -> { | |||
before("", authenticationHelper::checkAdminUserAnd403); | |||
before("", authenticationHelper::checkAdminUserOrGroupAdminUserAnd403); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the tests are there now in spark/spark-spa/src/test/groovy/com/thoughtworks/go/spark/spa/PipelinesControllerTest.groovy
:
@Nested
class Security implements SecurityTestTrait, GroupAdminUserSecurity { ... }
@kritika-singh3 @maheshp Going to send this through the build and merge when green. Sorry I didn't see this PR earlier. |
No description provided.