Add missing working dir replacement during agent duplication#6979
Merged
bdpiprava merged 1 commit intogocd:masterfrom Sep 23, 2019
SebastianGoral-freenet:fix_multiple_agents
Merged
Add missing working dir replacement during agent duplication#6979bdpiprava merged 1 commit intogocd:masterfrom SebastianGoral-freenet:fix_multiple_agents
bdpiprava merged 1 commit intogocd:masterfrom
SebastianGoral-freenet:fix_multiple_agents
Conversation
|
|
Contributor
|
@SebastianGoral-md PR LGTM. Context: This is required if installed agent version < 19.6.0 and then upgraded to version >= 19.6.0. During the upgrade, the wrapper-properties.conf file will be updated with the wrapper_working_dir=/var/lib/go-agent. As wrapper-properties.conf is included at the end in wrapper.conf file, It will override the property(wrapper_working_dir) configured in Earlier script to run multiple agents is only updating the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: # none
Description: While using the provided script to duplicate an agent, we noticed that the working dir in the wrapper-properties.conf was not updated. This caused the new agents to fail during startup with the message "Already running agent launcher in this folder.".