Authorize agents remoting by UUID #8877
Merged
+405
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Validate agent UUID during remoting requests to prevent clients from acting on behalf of other agents
Prior to this change, it was possible for an authenticated agent to act on behalf of another agent. This is a security issue because if one agent is compromised, an attacker could request work or perform other duties intended for other agents. This was possible because the UUID to perform work was sourced from the deserialized object stream and not verified to be the same UUID that was permitted by the authentication filter. Essentially, an authenticated client could request work for any arbitrary agent. This would give access to decrypted secrets for a build.
This commit introduces a custom
HttpInvokerServiceExporterthat validates the UUID from theX-Agent-GUIDheader matches the UUID from the deserializedAgentRuntimeInfoandAgentIdentifierobjects and returns an appropriate error code when this validation fails.