Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a course has a free access plan course enrollment restrictions are being ignored #266

Open
thomasplevy opened this issue Dec 15, 2016 · 2 comments

Comments

@thomasplevy
Copy link
Member

commented Dec 15, 2016

date restrictions should be factored into account here

Recreation Steps

  1. Create course with course start & end dates
  2. Create a free access plan for the course
  3. Student will be able to enroll into course outside of the start & end dates

Expected

  • Student should not be able to enroll outside of those dates.

The issue here may be with the free enrollment form at https://github.com/gocodebox/lifterlms/blob/master/templates/product/free-enroll-form.php

There's a validation issue -- some validation is happening in templates while some is happening in the form submission controller (https://github.com/gocodebox/lifterlms/blob/master/includes/controllers/class.llms.controller.orders.php#L168). Validation for orders in general (free or paid) should be validated in one place rather than being split between the controller and the template(s)

@thomasplevy thomasplevy added this to the LifterLMS 3.3.0 milestone Dec 15, 2016
@thomasplevy thomasplevy modified the milestone: LifterLMS 3.3.0 Jan 4, 2017
@thomasplevy

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2018

Setup recreation steps as I've forgotten exactly what this is

@thomasplevy

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

free access plan with course start / end dates are being ignored?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.