if a course has a free access plan course enrollment restrictions are being ignored #266
date restrictions should be factored into account here
The issue here may be with the free enrollment form at https://github.com/gocodebox/lifterlms/blob/master/templates/product/free-enroll-form.php
There's a validation issue -- some validation is happening in templates while some is happening in the form submission controller (https://github.com/gocodebox/lifterlms/blob/master/includes/controllers/class.llms.controller.orders.php#L168). Validation for orders in general (free or paid) should be validated in one place rather than being split between the controller and the template(s)
The text was updated successfully, but these errors were encountered:
I was still allowed to enroll in the course. I believe if the course end date has passed, it should remove the access plan block or even deactivate the access plan or something.
Although, I have no gateway installed but this shouldn't be the problem.
And it was in the changelog that this was already fixed: https://github.com/gocodebox/lifterlms/blob/master/CHANGELOG.md#v3380---2020-04-29
@toyinogunseinde according to the issue's labels: Type: Bug, Status: Can't Recreate
So yeah the issue should still be there.
EDIT: Toyin added reference to the changelog where it looks like this issue should have been fixed.
Toyin and I discussed about this, here's a summary of the status quo:
In the previous comment #266 (comment), Toyin was actually referring to the fact that you can still enroll a course even if the Course End Date is passed (course closed). This is true, I don't think it's a bug, and in any case this is valid even for non free access plans.
Anyway according to what Toyin tested, though, the customer's (staging) site is now showing this issue anymore.
Now reading this the title of this very issue:
I think this is a duplicate of #1121 (or better, the opposite), even if in the issue description we can read:
But as said above, if we're talking about course start and end dates I don't think this is a real bug - users can change the enrollment dates according to the course opening dates, if that's what they want.
So I'm going to close this (fixed by #1123).
Whoever thinks I'm wrong please:
This is correct. This is the way it should work and it's not a bug.
Enrollment Dates and Course Dates (the time period when you are eligible to complete content) are two separate concepts with their own sets of restriction rules.
Ideally if you have a course which ends you'd want to setup enrollment dates to match that but you don't have to.
Perhaps we should have a discussion around whether or not the feature should be adjusted but it's not technically a bug because it's doing what it semantically should do -- control access to content within a course - the enrollment dates control the enrollment period. Use them both and you're good to go.