Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a course has a free access plan course enrollment restrictions are being ignored #266

Closed
thomasplevy opened this issue Dec 15, 2016 · 7 comments

Comments

@thomasplevy
Copy link
Member

@thomasplevy thomasplevy commented Dec 15, 2016

date restrictions should be factored into account here

Recreation Steps

  1. Create course with course start & end dates
  2. Create a free access plan for the course
  3. Student will be able to enroll into course outside of the start & end dates

Expected

  • Student should not be able to enroll outside of those dates.

The issue here may be with the free enrollment form at https://github.com/gocodebox/lifterlms/blob/master/templates/product/free-enroll-form.php

There's a validation issue -- some validation is happening in templates while some is happening in the form submission controller (https://github.com/gocodebox/lifterlms/blob/master/includes/controllers/class.llms.controller.orders.php#L168). Validation for orders in general (free or paid) should be validated in one place rather than being split between the controller and the template(s)

@thomasplevy thomasplevy added this to the LifterLMS 3.3.0 milestone Dec 15, 2016
@thomasplevy thomasplevy removed this from the LifterLMS 3.3.0 milestone Jan 4, 2017
@thomasplevy thomasplevy removed this from the LifterLMS 3.3.0 milestone Jan 4, 2017
@thomasplevy
Copy link
Member Author

@thomasplevy thomasplevy commented Jun 5, 2018

Setup recreation steps as I've forgotten exactly what this is

@thomasplevy thomasplevy added this to the Scrub June 2018 milestone Jun 5, 2018
@thomasplevy thomasplevy self-assigned this Jun 5, 2018
@actual-saurabh actual-saurabh removed this from the Scrub June 2018 milestone Jul 3, 2018
@actual-saurabh actual-saurabh added this to the Scrub July 2018 milestone Jul 3, 2018
@thomasplevy thomasplevy removed this from the Scrub July 2018 milestone Aug 8, 2018
@thomasplevy thomasplevy added this to the Scrub August 2018 milestone Aug 8, 2018
@thomasplevy thomasplevy removed this from the Scrub August 2018 milestone Sep 5, 2018
@thomasplevy thomasplevy added this to the Scrub September 2018 milestone Sep 5, 2018
@thomasplevy thomasplevy removed this from the Scrub September 2018 milestone Sep 5, 2018
@thomasplevy thomasplevy added this to the Scrub September 2018 milestone Sep 5, 2018
@thomasplevy thomasplevy removed this from the Scrub September 2018 milestone Oct 2, 2018
@thomasplevy thomasplevy added this to the Scrub October 2018 milestone Oct 2, 2018
@thomasplevy thomasplevy removed this from the Scrub October 2018 milestone Nov 16, 2018
@thomasplevy thomasplevy added this to the Scrub November 2018 milestone Nov 16, 2018
@thomasplevy thomasplevy removed this from the Scrub November 2018 milestone Dec 11, 2018
@thomasplevy thomasplevy added this to the Scrub December 2018 milestone Dec 11, 2018
@thomasplevy thomasplevy removed this from the Scrub December 2018 milestone Jan 8, 2019
@thomasplevy thomasplevy added this to the Scrub January 2019 milestone Jan 8, 2019
@thomasplevy thomasplevy removed this from the Scrub January 2019 milestone Feb 5, 2019
@thomasplevy thomasplevy added this to the Scrub February 2019 milestone Feb 5, 2019
@thomasplevy
Copy link
Member Author

@thomasplevy thomasplevy commented Feb 5, 2019

free access plan with course start / end dates are being ignored?

@thomasplevy thomasplevy added this to the Scrub March 2019 milestone Mar 5, 2019
@thomasplevy thomasplevy removed this from the Scrub March 2019 milestone Apr 9, 2019
@thomasplevy thomasplevy added this to the Scrub April 2019 milestone Apr 9, 2019
@thomasplevy thomasplevy removed this from the Scrub April 2019 milestone May 7, 2019
@thomasplevy thomasplevy added this to the Scrub May 2019 milestone May 7, 2019
@actual-saurabh actual-saurabh removed this from the Scrub May 2019 milestone Jun 5, 2019
@actual-saurabh actual-saurabh added this to the Scrub June 2019 milestone Jun 5, 2019
@actual-saurabh actual-saurabh removed this from the Scrub June 2019 milestone Jun 5, 2019
@actual-saurabh actual-saurabh added this to the Scrub June 2019 milestone Jun 5, 2019
@thomasplevy thomasplevy removed this from the Scrub June 2019 milestone Jul 2, 2019
@thomasplevy thomasplevy added this to the Scrub July 2019 milestone Jul 2, 2019
@thomasplevy thomasplevy removed this from the Scrub July 2019 milestone Oct 1, 2019
@thomasplevy thomasplevy added this to the Future milestone Oct 1, 2019
@toyinogun
Copy link

@toyinogun toyinogun commented May 20, 2020

@thomasplevy @eri-trabiccolo I don't think this bug was fixed. I just created a free course locally and set the course end date to 18th May 2020.

I was still allowed to enroll in the course. I believe if the course end date has passed, it should remove the access plan block or even deactivate the access plan or something.

Although, I have no gateway installed but this shouldn't be the problem.

And it was in the changelog that this was already fixed: https://github.com/gocodebox/lifterlms/blob/master/CHANGELOG.md#v3380---2020-04-29
"Fixed an issue causing free access plans to bypass course enrollment restrictions like capacity and enrollment time periods."

HS-122205

@eri-trabiccolo
Copy link
Member

@eri-trabiccolo eri-trabiccolo commented May 20, 2020

@toyinogunseinde according to the issue's labels: Type: Bug, Status: Can't Recreate
and the fact that this issue is still open I agree with you: this bug is not fixed.
I think that Thomas, as stated in his second comment, just forgot how to reproduce it, that's why he added Status: Can't Recreate.
Those are only my speculations of course :D

So yeah the issue should still be there.

EDIT: Toyin added reference to the changelog where it looks like this issue should have been fixed.

@eri-trabiccolo
Copy link
Member

@eri-trabiccolo eri-trabiccolo commented May 20, 2020

Toyin and I discussed about this, here's a summary of the status quo:

  1. In the LifterLMS 3.38.0 changelog we can read:
    "Fixed an issue causing free access plans to bypass course enrollment restrictions like capacity and enrollment time periods."
    enrollment restrictions: capacity and enrollment time periods are the keys here.
    As matter of fact that refers to the issue #1121, that it has been actually fixed.

  2. About the HS-122205 ticket:
    It was not clear whether or not the customer was still experiencing issues with the enrollment restrictions on free access plans OR with course dates (which are different concepts and settings).

In the previous comment #266 (comment), Toyin was actually referring to the fact that you can still enroll a course even if the Course End Date is passed (course closed). This is true, I don't think it's a bug, and in any case this is valid even for non free access plans.

Anyway according to what Toyin tested, though, the customer's (staging) site is now showing this issue anymore.

Finally

Now reading this the title of this very issue:
if a course has a free access plan course enrollment restrictions are being ignored

I think this is a duplicate of #1121 (or better, the opposite), even if in the issue description we can read:

  1. Create course with course start & end dates
  2. Student will be able to enroll into course outside of the start & end dates
    and that's a little bit misleading.

But as said above, if we're talking about course start and end dates I don't think this is a real bug - users can change the enrollment dates according to the course opening dates, if that's what they want.

So I'm going to close this (fixed by #1123).

Whoever thinks I'm wrong please:

  1. say it quietly adding that I'm beautiful on the other hand
  2. re-open this
  3. motivate

Thanks!

@thomasplevy
Copy link
Member Author

@thomasplevy thomasplevy commented May 20, 2020

In the previous comment #266 (comment), Toyin was actually referring to the fact that you can still enroll a course even if the Course End Date is passed (course closed). This is true, I don't think it's a bug, and in any case this is valid even for non free access plans.

This is correct. This is the way it should work and it's not a bug.

Enrollment Dates and Course Dates (the time period when you are eligible to complete content) are two separate concepts with their own sets of restriction rules.

Ideally if you have a course which ends you'd want to setup enrollment dates to match that but you don't have to.

Perhaps we should have a discussion around whether or not the feature should be adjusted but it's not technically a bug because it's doing what it semantically should do -- control access to content within a course - the enrollment dates control the enrollment period. Use them both and you're good to go.

@toyinogun
Copy link

@toyinogun toyinogun commented May 20, 2020

Thanks for the clarification @thomasplevy and @eri-trabiccolo. I was obviously confused. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants