Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inefficient calls to get_the_post_thumbnail in various templates #322

Closed
thomasplevy opened this issue May 2, 2017 · 1 comment

Comments

@thomasplevy
Copy link
Member

@thomasplevy thomasplevy commented May 2, 2017

lesson / course thumbnails are calling get_the_post_thumbnail() where has_post_thumbnail() should be being used instead

this results in overall inefficent code but can cause issues when other plugins/themes add html to using filters attached to get_the_post_thumbnail()

WP Overlays plugin causes PHP timeout issues on courses with a large number of lessons as a result

@actual-saurabh

This comment has been minimized.

Copy link
Contributor

@actual-saurabh actual-saurabh commented Jun 7, 2018

thomasplevy added a commit that referenced this issue Jun 7, 2018
Fix #322 to use has_post_thumbnail to conditionally display featured …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.