Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment i before return True #246

Merged
merged 2 commits into from Oct 28, 2018

Conversation

@nigelbabu
Copy link
Contributor

@nigelbabu nigelbabu commented Oct 27, 2018

The counter does not get incremented at all at the moment

The counter does not get incremented at all at the moment
@nigelbabu
Copy link
Contributor Author

@nigelbabu nigelbabu commented Oct 27, 2018

There doesn't seem to be any tests for htmlelement.go, so I haven't added one. If I have somehow missed them, please let me know.

Loading

Copy link
Member

@asciimoo asciimoo left a comment

Thanks for the fix.

Loading

@asciimoo asciimoo merged commit 8be5ab8 into gocolly:master Oct 28, 2018
1 check failed
Loading
@nigelbabu nigelbabu deleted the fix-index-for-each-with-brk branch Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants