New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment i before return True #246

Merged
merged 2 commits into from Oct 28, 2018

Conversation

Projects
None yet
2 participants
@nigelbabu
Copy link
Contributor

nigelbabu commented Oct 27, 2018

The counter does not get incremented at all at the moment

Increment i before return True
The counter does not get incremented at all at the moment
@nigelbabu

This comment has been minimized.

Copy link
Contributor Author

nigelbabu commented Oct 27, 2018

There doesn't seem to be any tests for htmlelement.go, so I haven't added one. If I have somehow missed them, please let me know.

@asciimoo
Copy link
Member

asciimoo left a comment

Thanks for the fix.

@asciimoo asciimoo merged commit 8be5ab8 into gocolly:master Oct 28, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@nigelbabu nigelbabu deleted the nigelbabu:fix-index-for-each-with-brk branch Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment