Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to tweet #2055

Merged
merged 7 commits into from Oct 12, 2021
Merged

Click to tweet #2055

merged 7 commits into from Oct 12, 2021

Conversation

jonathanbardo
Copy link
Member

@jonathanbardo jonathanbardo commented Oct 4, 2021

Description

Cleanup some CSS styles in click-to-tweet

@jonathanbardo
Copy link
Member Author

This is related to godaddy-wordpress/go#698

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the emails on this one. I was right about to merge when I realized that these styles would break in themes other than Go. We need another solution that is cross theme compatible.

image

@jonathanbardo
Copy link
Member Author

Oh good call there. Will fix the problematic section in Go instead.

@jonathanbardo
Copy link
Member Author

@AnthonyLedesma I implemented Go specific style here. Styles should be back to normal in twenty * themes. godaddy-wordpress/go#699

@jonathanbardo
Copy link
Member Author

This is what I'm seeing in twenty twenty one now.
image

@cypress
Copy link

cypress bot commented Oct 6, 2021



Test summary

4 0 0 0


Run details

Project CoBlocks
Status Passed
Commit ac0b496
Started Oct 6, 2021 8:32 PM
Ended Oct 6, 2021 8:33 PM
Duration 00:52 💡
OS Linux Debian - 10.6
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR in TwentyTwentyone I am seeing that the SVG icon is missing now:
image
image

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@jonathanbardo jonathanbardo merged commit 45796d2 into master Oct 12, 2021
@jonathanbardo jonathanbardo deleted the click-to-tweet branch October 12, 2021 14:17
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants