Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ical file parser issues and CSS overhaul #2088

Merged
merged 1 commit into from Oct 15, 2021
Merged

Conversation

jonathanbardo
Copy link
Member

Description

This would fix some oddities related to #1435.

Screenshots

Before:

Screen Shot 2021-10-14 at 2 24 48 PM

After:

Screen Shot 2021-10-14 at 2 26 37 PM

Types of changes

  • Fix PHP errors in class-coblocks-ical related to old use of Carbon class.
  • Move iCal calendar placeholder to use form and submit action to improve accessibility.
  • Overhaul CSS to look like maps placeholder.

@cypress
Copy link

cypress bot commented Oct 14, 2021



Test summary

8 0 0 0


Run details

Project CoBlocks
Status Passed
Commit 5498759
Started Oct 14, 2021 7:12 PM
Ended Oct 14, 2021 7:14 PM
Duration 01:09 💡
OS Linux Debian - 11.0
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@snovosel snovosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end

@jonathanbardo jonathanbardo merged commit e026211 into master Oct 15, 2021
@jonathanbardo jonathanbardo deleted the ical-parsing branch October 15, 2021 14:47
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants