Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space between figure and content on the Services block #846

Merged
merged 4 commits into from Sep 17, 2019

Conversation

richtabor
Copy link
Contributor

Currently we rely on the heading element to properly add spacing between the Services block figure and content below it. This means that whenever there's content without a heading block first - the block content is pressed right up against the image.

This PR removes the margin top applied to headings, instead applying a margin-bottom to the content div.

Screenshot of before:
Screen_Shot_2019-09-09_at_2 44 20_PM

@richtabor richtabor added this to the Next Release milestone Sep 10, 2019
@richtabor richtabor self-assigned this Sep 10, 2019
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in Chrome, FireFox, IE11 and Edge. Approved!

figureSpacingExample

@richtabor richtabor merged commit d91b291 into master Sep 17, 2019
@richtabor richtabor deleted the tweak-services-figure-margin branch September 17, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants