Fix warnings by upgrading to eslint@5 everywhere along with ecmaVersion: 9
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indexzero
requested review from
DullReferenceException,
Swaagie and
samshull
samshull
approved these changes
Dec 11, 2018
Contributor
samshull
left a comment
samshull
left a comment
There was a problem hiding this comment.
+1, but I would encourage a beta release of this PR that I could test in a few relevant applications/repos.
Contributor
Author
|
That was my plan @samshull once I get the necessary 👍:
Most CI will pass except for |
Contributor
Author
|
Travis is green
You know what they say
|
wcole1-godaddy
pushed a commit
that referenced
this pull request
Oct 13, 2025
…ecmaVersion: 9` (#74) * [dist] Add .gitattributes * [dist] Bump all the versions. * [dist] Last "eslint" version to 5 * [dist] More package-lock.json files * [dist] Last two major bumps that were overlooked. * [doc] Update CHANGELOG.md for `eslint-config-godaddy-react`. * [dist fix] All package-lock.json files up-to-date. Target latest `node` versions with Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #73.
eslint-config-godaddythat package neededeslint@5.eslint-config-godaddythey also needed to be upgraded toeslint@5.eslint-plugin-moncha.eslint-config-godaddy@3has not yet been publlished.