Skip to content

[proposal] Making most peerDependencies -> dependencies #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2020
Merged

[proposal] Making most peerDependencies -> dependencies #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac736ed
[proposal] Opening up dep versioning and removing most peerDependencies
fabiomcosta Nov 22, 2019
f115b3c
updating based on CR
fabiomcosta Nov 28, 2019
ba085c8
using proper versioning
fabiomcosta Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-config-godaddy-es5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "eslint-config-godaddy-es5",
"version": "3.1.0",
"description": "ESLint config for consistent style in ES5 (Node & React) projects at GoDaddy.",
"license": "MIT",
"scripts": {
"lint": "eslint .",
"pretest": "npm run --silent lint",
Expand Down Expand Up @@ -34,7 +35,6 @@
"eslint-plugin-mocha": "^5.2.0",
"eslint-plugin-react": "^7.11.1"
},
"license": "MIT",
"devDependencies": {
"eslint": "^6.0.1",
"eslint-config-godaddy-react": "^5.0.0",
Expand Down
1,152 changes: 531 additions & 621 deletions packages/eslint-config-godaddy-flow/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 9 additions & 16 deletions packages/eslint-config-godaddy-flow/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "eslint-config-godaddy-flow",
"version": "3.0.0",
"description": "ESLint config for consistent style in node projects using Flow at GoDaddy.",
"license": "MIT",
"scripts": {
"lint": "eslint .",
"pretest": "npm run --silent lint",
Expand All @@ -24,25 +25,17 @@
"bin": {
"eslint-godaddy-flow": "bin/eslint-godaddy-flow"
},
"dependencies": {
"eslint-config-godaddy": "^4.0.0"
},
"peerDependencies": {
"babel-eslint": ">=7.2.1 <11.0.0",
"eslint": "^6.1.0",
"eslint": ">=6.0.0"
},
"dependencies": {
"babel-eslint": "^10.0.3",
"eslint-config-godaddy": "^4.0.0",
Copy link
Contributor Author

@fabiomcosta fabiomcosta Nov 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to use the next version for these, can I have publish permission please?

"eslint-plugin-babel": "^5.3.0",
"eslint-plugin-flowtype": "^4.2.0",
"eslint-plugin-json": "^1.4.0",
"eslint-plugin-mocha": "^5.3.0"
Copy link
Member

@Swaagie Swaagie Dec 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these can be just removed. I do understand the peerDependencies messages might be annoying. This plugin extends from the base:

javascript/packages/eslint-config-godaddy-flow/index.js

Line 3 in f115b3c

require('./extends')('eslint-config-godaddy')
which in turn has

javascript/packages/eslint-config-godaddy/index.js

Line 10 in f115b3c

plugins: ['mocha', 'json'],

Iirc this will just lead to eslint crashing on not finding the modules.

Copy link

@DullReferenceException DullReferenceException Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will now installed as regular dependencies, though, so eslint should be able to find all the relevant plugins, no? It doesn't make sense to me that they're peer dependencies; installing our canned config should install all the relevant plugins for you. All other eslint configs I've seen do this.

Copy link
Member

@Swaagie Swaagie Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stand corrected overlooked them here https://github.com/godaddy/javascript/pull/88/files#diff-502dbc4a5275e8ef5e9db3306e47d92cR31

"eslint-plugin-flowtype": "^4.5.2"
},
"license": "MIT",
"devDependencies": {
"babel-eslint": "^10.0.2",
"eslint": "^6.1.0",
"eslint-find-rules": "^3.4.0",
"eslint-plugin-babel": "^5.3.0",
"eslint-plugin-flowtype": "^4.2.0",
"eslint-plugin-json": "^1.4.0",
"eslint-plugin-mocha": "^5.3.0"
"eslint": "^6.7.1",
"eslint-find-rules": "^3.4.0"
}
}
Loading