From 29a79358c4965a0766f4c4fd3668a963359226b7 Mon Sep 17 00:00:00 2001 From: Silas Boyd-Wickizer Date: Tue, 13 Feb 2018 09:14:08 -0800 Subject: [PATCH] chore(pods.log): remove the deprarecated `pods.log` function. (#196) BREAKING CHANGE: `pods.log` doesn't follow the kubernetes-client API conventions. Replace uses of `pods.log('foo')` with `pods('foo').log.get()`. --- lib/pods.js | 20 -------------------- test/pods.test.js | 14 -------------- 2 files changed, 34 deletions(-) diff --git a/lib/pods.js b/lib/pods.js index bc7d4bbe..45200816 100644 --- a/lib/pods.js +++ b/lib/pods.js @@ -1,7 +1,5 @@ 'use strict'; -const util = require('util'); - const BaseObject = require('./base'); const ContainerBaseObject = require('./container-base-object'); @@ -39,24 +37,6 @@ class Pods extends BaseObject { }), name: options.name || 'pods' })); - - this.log = util.deprecate( - this.log.bind(this), - 'pods.log is deprecated and will be removed in 4.0.0. ' + - 'Use pods(name).log.get instead.'); - } - - /** - * @deprecated Will be removed in 4.0.0. Use pods(name).log.get instead. - * @param {RequestOptions|string} options - GET options, or resource name - * @param {callback} cb - The callback that handles the response - * @returns {Stream} If cb is falsy, return a Stream - */ - log(options, cb) { - if (typeof options === 'string') options = { name: options }; - return this.get( - Object.assign({}, options, { name: `${ options.name }/log` }), - cb); } } diff --git a/test/pods.test.js b/test/pods.test.js index 65959766..c146a582 100644 --- a/test/pods.test.js +++ b/test/pods.test.js @@ -173,13 +173,6 @@ describe('lib.pods', () => { done(); }); }); - only('unit', 'returns the Pod via the legacy method', done => { - common.api.ns(common.currentName).pods.get('test-pod', (err, pod) => { - assume(err).is.falsy(); - assume(pod.kind).is.equal('Pod'); - done(); - }); - }); }); describe('.delete', () => { @@ -216,13 +209,6 @@ describe('lib.pods', () => { done(); }); }); - only('unit', 'returns log contents via legacy method', done => { - common.api.ns(common.currentName).pods.log('test-pod', (err, contents) => { - assume(err).is.falsy(); - assume(contents).is.equal('some log contents'); - done(); - }); - }); }); common.afterTesting('int', common.cleanupName);