feat(promises): if caller doesn't specify a callback, return a promise (

#193)

Resolves #189

BREAKING CHANGE: This removes the (deprecated) `request`-like behavior of
returning a stream when the caller omits a callback. Use `.getStream` (instead
of `.get` without a callback) to get a stream.

README.md

@@ -71,22 +71,9 @@ const core = new Api.Core(Api.config.fromKubeconfig());
 
 ### **Experimental** support for promises and async/await
 
-kubernetes-client exposes **experimental** support for promises via
-the `promises` option passed to API group constructors. The API is the
-same, except for the functions that previously took a callback
-(*e.g.*, `.get`). Those functions now return a promise.
-
-```js
-// Notice the promises: true
-const core = new Api.Core({
-  url: 'http://my-k8s-api-server.com',
-  version: 'v1',  // Defaults to 'v1'
-  promises: true,  // Enable promises
-  namespace: 'my-project' // Defaults to 'default'
-});
-```
-
-and then:
+kubernetes-client has **experimental** support for promises. If you
+omit callbacks an HTTP method function (*e.g.*, `.get`), it will
+return a promise.
 
 ```js
 core.namespaces.replicationcontrollers('http-rc').get()
@@ -99,13 +86,6 @@ or with `async/await`:
 print(null, await core.namespaces.replicationcontrollers('http-rc').get());
 ```
 
-You can invoke promise-based and callback-based functions explictly:
-
-```js
-print(null, await core.namespaces.replicationcontrollers('http-rc').getPromise());
-core.namespaces.replicationcontrollers('http-rc').getCb(print);
-```
-
 ### Creating and updating
 
 kubernetes-client objects expose `.post`, `.patch`, and `.put`

lib/base.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const promisify = require('util.promisify');
+const promy = require('promy');
 
 const matchExpression = require('./match-expression');
 
@@ -76,10 +76,7 @@ class BaseObject extends CallableObject {
 
     const apiFunctions = ['delete', 'get', 'patch', 'post', 'put'];
     apiFunctions.forEach(func => {
-      this[`${ func }Promise`] = promisify(this[`_${ func }`].bind(this));
-      this[`${ func }Cb`] = this[`_${ func }`].bind(this);
-      if (this.api.resourceConfig.promises) this[func] = this[`${ func }Promise`];
-      else this[func] = this[`${ func }Cb`];
+      this[func] = promy(this[`_${ func }`].bind(this));
     });
   }
 
@@ -96,7 +93,7 @@ class BaseObject extends CallableObject {
       options = { name: options };
     }
     this.api.delete({ path: this._path(options), qs: options.qs, body: options.body },
-                    cb200(cb));
+      cb200(cb));
   }
 
   _path(options) {
@@ -154,7 +151,7 @@ class BaseObject extends CallableObject {
    */
   _post(options, cb) {
     this.api.post({ path: this._path(options), body: options.body },
-                  cb200(cb));
+      cb200(cb));
   }
 
   /**

package.json

@@ -33,8 +33,8 @@
     "async": "^2.6.0",
     "js-yaml": "^3.10.0",
     "lodash.merge": "^4.6.0",
-    "request": "^2.83.0",
-    "util.promisify": "^1.0.0"
+    "promy": "^0.1.0",
+    "request": "^2.83.0"
   },
   "devDependencies": {
     "@types/node": "^9.4.2",