fix(CRDs): Use versions list for spec paths
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it's only possible to specify one api version for CRD objects via the deprecated `version` field when building their spec paths. This commit adds support for building spec paths for multiple CRD versions specified in the `versions` list while maintaining compatibility with `version`. Fixes godaddy#458
|
Published with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's only possible to specify one api
version for CRD objects via the deprecated
versionfield when building their spec paths.This commit adds support for building spec paths
for multiple CRD versions specified in the
versionslist while maintaining compatibilitywith
version.Fixes #458