Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] Add OpenApi docs, remove `Checks`, remove `/assets/:hash` #39

Merged
merged 6 commits into from Mar 4, 2019

Conversation

Projects
None yet
4 participants
@msluther
Copy link
Contributor

commented Feb 28, 2019

This will probably need some tweaking as we go, but here are the initial OpenApi docs.

While adding them, spoke offline with @jcrugzz and since we were going to remove Checks and the assets route in a future release, now seemed like a good time to do so, rather than try to document APIs that will just removed. I can put them back and just leave them undocumented if we'd rather do that and not do the major bump now.

There are probably still some remnants of both pieces and I mostly just took out the top-level routes and README docs.

msluther added some commits Feb 28, 2019

@msluther msluther requested review from jcrugzz and indexzero Feb 28, 2019

@indexzero
Copy link
Member

left a comment

awesome-awesome-to-the-max

Show resolved Hide resolved package.json Outdated
@jcrugzz

jcrugzz approved these changes Mar 1, 2019

Copy link
Member

left a comment

Overall LGTM, just a couple things

Show resolved Hide resolved lib/routes/swagger.js Outdated
Show resolved Hide resolved lib/routes/index.js Outdated
Show resolved Hide resolved package-lock.json Outdated

@msluther msluther requested a review from 3rd-Eden Mar 4, 2019

@msluther msluther merged commit 7a5d1fd into master Mar 4, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (godaddy) No new issues
Details

@msluther msluther deleted the swagger branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.