Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public warehouse Package Configuration #59

Merged
merged 15 commits into from Jun 3, 2019

Conversation

Projects
None yet
2 participants
@SivanMehta
Copy link
Member

commented May 28, 2019

Summary

As a developer I should be able to read warehouse package configuration. Or in the form of question: "How do I make my package warehouse.ai ready?"

Addresses #17 and #18, but most importantly #46

CHANGELOG

I added the guide to the README

Test Plan

Read the doc

SivanMehta added some commits May 28, 2019

@SivanMehta SivanMehta closed this May 28, 2019

@SivanMehta SivanMehta reopened this May 28, 2019

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md
Show resolved Hide resolved README.md Outdated
@msluther

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Make sure to also associated with the related github issues. And then to come back and update this documentation when extract-config is fully implemented everywhere.

@SivanMehta SivanMehta force-pushed the package-docs branch from 6ceabca to c49f995 May 29, 2019

@SivanMehta SivanMehta marked this pull request as ready for review May 29, 2019

Show resolved Hide resolved README.md Outdated
README.md Outdated
is important that you setup an `.npmrc` file that provides proper authorization
so that `warehouse.ai` can properly `npm install` and build your assets. For
example, if you're using a private registry you may need to add this to an
`.npmrc` file:

This comment has been minimized.

Copy link
@msluther

msluther May 29, 2019

Contributor

Your ~/.npmrc file isn't going to help wrhs side-publish to a registry that has to be setup with warehouse.ai's configuration. Your ~/.npmrc is so that you can communicate with warehouse.ai.
The myRepo/.npmrc is there if you're using a private registry to install from. and you need that, but you should NOT put credentials in that file since you'll want to commit that to your repo.

Show resolved Hide resolved README.md
Show resolved Hide resolved README.md

SivanMehta added some commits May 29, 2019

@SivanMehta SivanMehta merged commit 0741afd into master Jun 3, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (godaddy) No manifest changes detected

@SivanMehta SivanMehta deleted the package-docs branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.