Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add simple unicode char support for Strlen #18

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

doun commented Dec 25, 2012

using char2nr(char)>255, it just works for me.

add simple unicode support of strlen
using char2nr(char)>255, it just works for me.
Owner

godlygeek commented Dec 25, 2012

I don't understand what this changeset is supposed to accomplish - as far as I can see, what it's doing is making it so that most unicode characters are treated as doublewidth instead of single width - and that's just wrong. For instance, this code would recognize ä as single width (because it's codepoint 228), but ā as doublewidth (because it's codepoint 257). Both of those are single-width characters, though.

@godlygeek godlygeek closed this Jan 8, 2013

doun commented Jan 8, 2013

using strdisplaywidth is nice!

Owner

godlygeek commented Jan 9, 2013

Yes, strdisplaywidth is a good way to solve the problem in vim 7.3. I have some ideas about how to do it properly on vim 7.2, but nothing I'm ready to publish yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment