Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything is successful unless version number screws up #47

Closed
Coder2195Text opened this issue Dec 11, 2022 · 3 comments · Fixed by #48
Closed

Everything is successful unless version number screws up #47

Coder2195Text opened this issue Dec 11, 2022 · 3 comments · Fixed by #48

Comments

@Coder2195Text
Copy link

  --- stderr
  Build selected for Linux/Windows.
  thread 'main' panicked at 'failed to parse Godot version '4.0.beta8.mono.official.45cac42c0
  ': Regex capture failed', /home/coder2195/.cargo/git/checkouts/gdextension-25c68fb170a9fb9d/eaefd45/godot-codegen/src/godot_exe.rs:87:13
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@RealAstolfo
Copy link
Contributor

RealAstolfo commented Dec 11, 2022

similar issue with me,
` Found 'godot4' executable in PATH: /usr/bin/godot4
cargo:rerun-if-changed=/usr/bin/godot4
Godot version: 4.0.beta8.gentoo.45cac42c0

--- stderr
Build selected for Linux/Windows.
thread 'main' panicked at 'failed to parse Godot version '4.0.beta8.gentoo.45cac42c0
': Regex capture failed', /home/dots/.cargo/git/checkouts/gdextension-25c68fb170a9fb9d/eaefd45/godot-codegen/src/godot_exe.rs:87:13
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace`

this function seems to be the fault https://github.com/godot-rust/gdextension/blob/fc41cc4ae2cb053e6a69006958269adf4fb091c4/godot-codegen/src/godot_version.rs#L29

my suggestion is to change the regex to accept everything after "4.0.beta" since those seem to be all that matters anyway

@RealAstolfo
Copy link
Contributor

RealAstolfo commented Dec 13, 2022

   Compiling bindgen v0.63.0
error: failed to run custom build command for `godot-core v0.1.0 (https://github.com/godot-rust/gdextension?branch=master#5513c001)`

Caused by:
  process didn't exit successfully: `/home/dots/Documents/Projects/Exorium-Godot/target/debug/build/godot-core-c8db86b873c89a88/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=/home/dots/.cargo/git/checkouts/gdextension-25c68fb170a9fb9d/5513c00/godot-codegen/input/gen/extension_api.json
  Found 'godot4' executable in PATH: /usr/bin/godot4
  cargo:rerun-if-changed=/usr/bin/godot4
  Godot version: 4.0.beta8.gentoo.45cac42c0


  --- stderr
  thread 'main' panicked at 'failed to parse Godot version '4.0.beta8.gentoo.45cac42c0
  ': Version substring cannot be parsed: `4.0.beta8.gentoo.45cac42c0
  `', /home/dots/.cargo/git/checkouts/gdextension-25c68fb170a9fb9d/5513c00/godot-codegen/src/godot_exe.rs:87:13

problem still exists for gentoo builds

Edit Bromeon: formatting

@Bromeon
Copy link
Member

Bromeon commented Dec 13, 2022

@RealAstolfo thanks for the heads-up, I'll look deeper into how this version looks exactly 👍

Edit: fixed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants