Added missing namespace prefixes to GDVIRTUAL macros #1864
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Nov 29, 2025
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
dsnopek
added
bug
Collaborator
|
Cherry-picked for 4.4 in PR #1890 |
Collaborator
|
Cherry-picked for 4.5 in PR #1891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codegen for the
GDVIRTUALmacros was missing the namespace and enum prefix for the method flags. This meant that any class declaration that tried to use a GDVIRTUAL macro would either have to be in thegodotnamespace, or would have to useusing namespace godot, neither of which is ideal.This change simply adds the prefixes, which means the above workarounds will no longer be necessary, allowing developers to use namespaces as they see fit in their custom Godot objects.