CMake: Make -fno-exceptions private #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
added
enhancement
enetheru
approved these changes
Nov 13, 2025
Collaborator
enetheru
left a comment
enetheru
left a comment
There was a problem hiding this comment.
yes, thank you. I should have made all flags private by default.
dsnopek
approved these changes
Nov 29, 2025
Collaborator
|
Thanks! |
Collaborator
|
Cherry-picked for 4.4 in PR #1890 |
Collaborator
|
Cherry-picked for 4.5 in PR #1891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables building a GDExtension with a third-party library that uses exceptions using CMake. Otherwise the -fno-exceptions` flag seems to extend to everything.
Some context: I'm trying to make a GDExtension that integrates the Orbecc SDK in Godot. This SDK is open source and uses exceptions. I had to make this change to successfully build it along with godot-cpp using CMake.
I am by no means good at CMake so tell me if I'm missing something obvious.
Thanks for all your work !