Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated code in Sync Audio #3150

Open
wants to merge 1 commit into
base: master
from

Conversation

@clemens-tolboom
Copy link
Contributor

clemens-tolboom commented Feb 6, 2020

Not sure I got this right but it seems like duplicate code to me.

Furthermore I'm not sure what we can use this time for as $player.play has no timing arguments to compensate for. There is no $player.playDelayed(time).

Shouldn't we use _physics_process for better timing?

Not sure I got this right but it seems like duplicate code to me.

Furthermore I'm not sure what we can use this **time** for as $player.play has no timing arguments to compensate for. There is no `$player.playDelayed(time)`.

Shouldn't we use `_physics_process` for better timing?
@Calinou Calinou added the enhancement label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.