From bd7eb30f2996d3f08fecd8fe198564a0369d6b91 Mon Sep 17 00:00:00 2001 From: Thygrrr Date: Sat, 23 Sep 2023 13:00:40 +0200 Subject: [PATCH] Update spatial_shader.rst The reference page suggests a very unfortunate lighting function that modulades the color values in ALBEDO again. This does not seem representative of the shading model. Also, it omitted LIGHT_COLOR; repalcing the ALBEDO term with LIGHT_COLOR gives a much more expected diffuse lighting example. --- tutorials/shaders/shader_reference/spatial_shader.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorials/shaders/shader_reference/spatial_shader.rst b/tutorials/shaders/shader_reference/spatial_shader.rst index eb2a8d99f92..de20778fe41 100644 --- a/tutorials/shaders/shader_reference/spatial_shader.rst +++ b/tutorials/shaders/shader_reference/spatial_shader.rst @@ -401,7 +401,7 @@ Below is an example of a custom light function using a Lambertian lighting model .. code-block:: glsl void light() { - DIFFUSE_LIGHT += clamp(dot(NORMAL, LIGHT), 0.0, 1.0) * ATTENUATION * ALBEDO; + DIFFUSE_LIGHT += clamp(dot(NORMAL, LIGHT), 0.0, 1.0) * ATTENUATION * LIGHT_COLOR; } If you want the lights to add together, add the light contribution to ``DIFFUSE_LIGHT`` using ``+=``, rather than overwriting it.