From 799478bfeafa715f98c35644020f1fd52cc87bce Mon Sep 17 00:00:00 2001 From: Saif Kandil <74428638+k0T0z@users.noreply.github.com> Date: Wed, 11 Oct 2023 12:29:54 +0300 Subject: [PATCH 1/3] fix generating *.out command in unit test doc Signed-off-by: Saif Kandil <74428638+k0T0z@users.noreply.github.com> --- .../development/core_and_modules/unit_testing.rst | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/contributing/development/core_and_modules/unit_testing.rst b/contributing/development/core_and_modules/unit_testing.rst index ffa912df170..e6eae3f9ee8 100644 --- a/contributing/development/core_and_modules/unit_testing.rst +++ b/contributing/development/core_and_modules/unit_testing.rst @@ -319,18 +319,24 @@ Therefore, the process of writing integration tests for GDScript is the followin if true # Missing colon here. print("true") -3. Generate ``*.out`` files to update the expected results from the output: +3. Change directory to the root of godot source repository. .. code-block:: shell - ./bin/ --gdscript-generate-tests godot-source/modules/gdscript/tests/scripts + cd godot + +4. Generate ``*.out`` files to update the expected results from the output: + + .. code-block:: shell + + ./bin/ --gdscript-generate-tests modules/gdscript/tests/scripts You may add the ``--print-filenames`` option to see filenames as their test outputs are generated. If you are working on a new feature that is causing hard crashes, you can use this option to quickly find which test file causes the crash and debug from there. -4. Run GDScript tests with: +5. Run GDScript tests with: .. code-block:: shell From b298d24b85845e9f927bf9f30aaea66a72f90727 Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Thu, 9 Nov 2023 12:43:44 +0100 Subject: [PATCH 2/3] Apply suggestions from code review --- contributing/development/core_and_modules/unit_testing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/development/core_and_modules/unit_testing.rst b/contributing/development/core_and_modules/unit_testing.rst index e6eae3f9ee8..dcff9ec645a 100644 --- a/contributing/development/core_and_modules/unit_testing.rst +++ b/contributing/development/core_and_modules/unit_testing.rst @@ -319,7 +319,7 @@ Therefore, the process of writing integration tests for GDScript is the followin if true # Missing colon here. print("true") -3. Change directory to the root of godot source repository. +3. Change directory to the Godot source repository root. .. code-block:: shell From 318d9e1f07f6b5ddf32512506530b34fe4643349 Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Thu, 9 Nov 2023 12:43:56 +0100 Subject: [PATCH 3/3] Apply suggestions from code review --- contributing/development/core_and_modules/unit_testing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/development/core_and_modules/unit_testing.rst b/contributing/development/core_and_modules/unit_testing.rst index dcff9ec645a..db276d4c27c 100644 --- a/contributing/development/core_and_modules/unit_testing.rst +++ b/contributing/development/core_and_modules/unit_testing.rst @@ -329,7 +329,7 @@ Therefore, the process of writing integration tests for GDScript is the followin .. code-block:: shell - ./bin/ --gdscript-generate-tests modules/gdscript/tests/scripts + bin/ --gdscript-generate-tests modules/gdscript/tests/scripts You may add the ``--print-filenames`` option to see filenames as their test outputs are generated. If you are working on a new feature that is causing