Update minimal websocket client example. #9455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aGuyWhoMadeGames
force-pushed
the
update-websockets
branch
from
2f6f2c2 to
ec0dcc3
Compare
skyace65
added
bug
area:manual
aGuyWhoMadeGames
force-pushed
the
update-websockets
branch
from
75d79fb to
653dbea
Compare
Contributor
Author
|
Thanks for the corrections. This is my first PR other than a few small fixes, so I wasn't aware of all of the guidelines. I fixed everything you said. |
tutorials/networking/websocket.rst
Outdated
| # The code will be -1 if the disconnection was not properly notified by the remote peer. | ||
| var code = socket.get_close_code() | ||
| print("WebSocket closed with code: %d. Clean: %s" % [code, code != -1]) | ||
| set_process(false) # Stop processing. |
Member
There was a problem hiding this comment.
Just one final nitpick, the code should be indented with spaces, not tabs, otherwise this is all good
Contributor
Author
There was a problem hiding this comment.
I converted the tabs to spaces. If it matters, shouldn't this be part of the lint though?
Member
There was a problem hiding this comment.
I'm not sure why it isn't but I think it's a limitation of the system, unsure
aGuyWhoMadeGames
force-pushed
the
update-websockets
branch
from
653dbea to
6324f35
Compare
aGuyWhoMadeGames
force-pushed
the
update-websockets
branch
from
6324f35 to
2afeaaf
Compare
AThousandShips
approved these changes
Jun 5, 2024
Member
|
Thanks! |
Contributor
|
Not sure why the PR changed the websocket address, but we moved away from
the one used in this PR because it was very unreliable (i.e. was offline
for a very long time).
…On Wed, Jun 5, 2024, 20:53 AThousandShips ***@***.***> wrote:
Thanks!
—
Reply to this email directly, view it on GitHub
<#9455 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM4C3U7U3NL5UPCFEFDRFTZF5NCJAVCNFSM6AAAAABIXLQZJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQG42DCNJVGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Contributor
Author
|
I changed the url because the previous one wasn't working, and all of the minimal examples I saw used the one I'm using here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new example is a combination of the old example and the example from the class reference.
This fixes #9138 and fixes #6631.