Skip to content

Commit

Permalink
X11: Link libgcc statically with use_static_cpp option
Browse files Browse the repository at this point in the history
We were already linking libstdc++ statically for official binaries,
protecting us against most portability issues. But apparently since
we started using GCC 7 for official builds, we also need to link
libgcc statically for at least 32-bit builds to be portable.

Fixes #16409.

(cherry picked from commit b526088)
  • Loading branch information
akien-mga authored and hpvb committed Feb 19, 2018
1 parent 5b04dcf commit 8372a40
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions platform/x11/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def get_opts():

return [
BoolVariable('use_llvm', 'Use the LLVM compiler', False),
BoolVariable('use_static_cpp', 'Link stdc++ statically', False),
BoolVariable('use_static_cpp', 'Link libgcc and libstdc++ statically for better portability', False),
BoolVariable('use_sanitizer', 'Use LLVM compiler address sanitizer', False),
BoolVariable('use_leak_sanitizer', 'Use LLVM compiler memory leaks sanitizer (implies use_sanitizer)', False),
BoolVariable('pulseaudio', 'Detect & use pulseaudio', True),
Expand Down Expand Up @@ -275,6 +275,6 @@ def configure(env):
env.Append(CPPFLAGS=['-m64'])
env.Append(LINKFLAGS=['-m64', '-L/usr/lib/i686-linux-gnu'])


# Link those statically for portability
if env['use_static_cpp']:
env.Append(LINKFLAGS=['-static-libstdc++'])
env.Append(LINKFLAGS=['-static-libgcc', '-static-libstdc++'])

0 comments on commit 8372a40

Please sign in to comment.