Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Direction" property for Particles is missing #13492

Closed
vybr opened this issue Dec 1, 2017 · 12 comments · Fixed by #26613
Closed

"Direction" property for Particles is missing #13492

vybr opened this issue Dec 1, 2017 · 12 comments · Fixed by #26613

Comments

@vybr
Copy link

@vybr vybr commented Dec 1, 2017

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot 3.0 Beta - Windows

Issue description:

It's no longer possible to specify the direction of Initial Velocity for particles it seems. I have to rotate the Particles2D object itself and change the particle angle to offset this. If I'm using gravity I also have to alter this based on whatever rotation I am currently using. It's really quite cumbersome.
Could this property be added back please? It's quite important for users who make heavy use of particles, like me.

@noidexe
Copy link
Contributor

@noidexe noidexe commented Dec 21, 2017

@vybr you can set Local Coords to false as a temporary workaround to avoid having to alter the gravity vector every time you rotate the particles2d object.

@akien-mga
Copy link
Member

@akien-mga akien-mga commented Jan 5, 2018

We have now entered release freeze for Godot 3.0 and want to focus only on release critical issues for that milestone. Therefore, we're moving this issue to the 3.1 milestone, though a fix may be made available for a 3.0.x maintenance release after it has been tested in the master branch during 3.1 development. If you consider that this issue is critical enough to warrant blocking the 3.0 release until fixed, please comment so that we can assess it more in-depth.

@akien-mga akien-mga removed this from the 3.0 milestone Jan 5, 2018
@akien-mga akien-mga added this to the 3.1 milestone Jan 5, 2018
@arccoza
Copy link

@arccoza arccoza commented Jan 25, 2018

I just ran into this, and it does throw you. The first thing you look to do after creating an emitter is point it somewhere, and when Godot 2.x had direction and the 3.x docs talk about direction in ParticlesMaterial, only for it to be absent in code is confusing and frustrating. This doesn't seem like a feature request, but a bug fix for a regression.

I understand that the particle system is marked for replacement with something shinier in 3.1, and I'm looking forward to those features, but for now this limits what can be done with particles without non-obvious workarounds, for a fairly fundamental feature.

Fixes:

  • Best option: Actually reinstate direction either in the node or the ParticlesMaterial resource, (or maybe make initial_velocity a vector).
  • Quickest option: Update the docs with a note about the missing feature and workarounds; such as rotating the emitter and manually adjusting the gravity vector, or disabling local_coords, with caveats.

@GammaGames
Copy link

@GammaGames GammaGames commented May 1, 2018

If this is an enhancement (as the issue is tagged) then the documentation should be updated to not list the setting.
If this is a bug, which it is, then the docs should have a note that it is currently not available in the build, with the note removed when the bug has been fixed.

@akien-mga
Copy link
Member

@akien-mga akien-mga commented May 2, 2018

@GammaGames A missing feature is not a bug, it's a missing feature. Otherwise all issues could be labeled as "bug". Once the feature is implemented, it will enhance the existing features of Particles.

@GammaGames
Copy link

@GammaGames GammaGames commented May 2, 2018

Then the documentation should be updated to stop advertising features that don't exist

akien-mga added a commit to godotengine/godot-docs that referenced this issue May 2, 2018
The parameter is not implemented in the gles3 renderer for now.
See godotengine/godot#13492.
@akien-mga
Copy link
Member

@akien-mga akien-mga commented May 2, 2018

Done: godotengine/godot-docs@a85c395

@Zylann
Copy link
Contributor

@Zylann Zylann commented Nov 4, 2018

Bumped into this too, it's also really annoying because the workaround of rotating the whole Particles2D node also rotates the emission shape.

@akien-mga akien-mga removed this from the 3.1 milestone Jan 9, 2019
@akien-mga akien-mga added this to the 3.2 milestone Jan 9, 2019
@reduz
Copy link
Member

@reduz reduz commented Jan 18, 2019

Not a bug so I wont work on it before 3.1, but if anyone wants to give it a try feel free

@terepaii
Copy link

@terepaii terepaii commented Feb 2, 2019

If nobody's working on this, mind if I take a stab?

@serados
Copy link
Contributor

@serados serados commented Feb 25, 2019

Hi @terepaii, are there any updates on your progress? I'm interested in giving this a go as well.

@terepaii
Copy link

@terepaii terepaii commented Feb 25, 2019

@serados I've made only a small bit of progress. Feel free to make a PR though. Not sure when I can take a look at this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants