3D in GLES2 is completely broken

[YeldhamDev]

Godot version:
2c9536b

Issue description:
With @reduz's most recent commits (likely 4f4e46e), the 3D rendering in GLES2 is completely broken as for now:

[muiroc]

in my case now both types of meshes (compressed and uncompressed) are visibile and the errors are gone (to clarify, this in webgl)

console output?
in webgl there were now errors about texureLod when the third parameter was an integer

EDIT wait a sec, actually I still need to rebuild the latest editor 😄

[YeldhamDev]

The output has a mountain of text, but here are the last errors printed:

 drivers/gles2/shader_gles2.cpp:196 - SceneShaderGLES2: Fragment shader compilation failed:
0:70(9): error: no matching function for call to `texture2DLod(sampler2D, vec2, float)'; candidates are:
0:70(2): error: `return' with wrong type error, in function `texel2DFetch' returning vec4

 drivers/gles2/shader_gles2.cpp:426 - Method/Function Failed, returning: __null
 drivers/gles2/shader_gles2.cpp:133 - Condition ' !version ' is true. returned: false
 drivers/gles2/shader_gles2.h:524 - Condition ' !version ' is true. returned: -1
 drivers/gles2/shader_gles2.h:524 - Condition ' !version ' is true. returned: -1
 drivers/gles2/shader_gles2.h:524 - Condition ' !version ' is true. returned: -1
 drivers/gles2/shader_gles2.h:524 - Condition ' !version ' is true. returned: -1
 drivers/gles2/shader_gles2.h:524 - Condition ' !version ' is true. returned: -1

[LinuxUserGD]

Same error (Arch Linux):

ERROR: _display_error_with_code: SceneShaderGLES2: Fragment shader compilation failed:
0:75(9): error: no matching function for call to `texture2DLod(sampler2D, vec2, float)'; candidates are:
0:75(2): error: `return' with wrong type error, in function `texel2DFetch' returning vec4

   At: drivers/gles2/shader_gles2.cpp:196.
ERROR: get_current_version: Method/Function Failed, returning: __null
   At: drivers/gles2/shader_gles2.cpp:426.
ERROR: bind: Condition ' !version ' is true. returned: false
   At: drivers/gles2/shader_gles2.cpp:133.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: get_uniform_location: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.cpp:522.
ERROR: get_uniform_location: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.cpp:522.
ERROR: get_uniform_location: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.cpp:522.
ERROR: get_uniform_location: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.cpp:522.
ERROR: get_uniform_location: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.cpp:522.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.
ERROR: _get_uniform: Condition ' !version ' is true. returned: -1
   At: drivers/gles2/shader_gles2.h:524.

[reduz]

OS, GPU and sample project ploz, because so far it works fine for me.

[YeldhamDev]

@reduz Manjaro GNU/Linux - Intel i5, Haswell-ULT

[LinuxUserGD]

Arch Linux (Antergos)
OpenGL ES 2.0 Renderer: Mesa DRI Intel(R) HD Graphics 620 (Kaby Lake GT2)
example: Platformer 3D demo

[reduz]

Oh I see, intel related. Will check it asap.

[LinuxUserGD]

But it works on Windows 10 64 bit

[santouits]

godot/drivers/gles2/shaders/scene.glsl

Line 659 in 2c9536b

#ifndef USE_GLES_OVER_GL

godot/drivers/gles2/shaders/cubemap_filter.glsl

Line 28 in 2c9536b

#ifndef USE_GLES_OVER_GL

godot/drivers/gles2/shaders/canvas.glsl

Line 218 in 2c9536b

#ifndef USE_GLES_OVER_GL

Those ifndef were added in the last commit and maybe some implementations of gles 2 need explicitely to enable EXT_shader_texture_lod or GL_ARB_shader_texture_lod for the functions to work. Remove them?

[reduz]

I don't know, texture lod is core for OpenGL 2.1, so on desktop it should not need any extension.

[reduz]

oh right, my mistake, I now realize it's not core. It only works on vertex programs in 2.1. Will fix ASAP.

[swarnimarun]

Yep it's not working for me but when I switch to the nvidia card in my laptop it seemed fine.... Need to check more I guess.
btw I am using Manjaro.

[LinuxUserGD]

So GL2 works?

[reduz]

Should work for everyone now

…

On Wed, Jan 23, 2019, 17:08 Linux User ***@***.*** wrote: So GL2 works? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#25263 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z269FFYMmJnFvSSpArUxwT5Hrhepyks5vGME3gaJpZM4aO_Yv> .

[LinuxUserGD]

Yes, it works now 👍