Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project manager no longer falls back to GLES2 on systems which don't support GLES3 #26806

Closed
akien-mga opened this Issue Mar 8, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@akien-mga
Copy link
Member

akien-mga commented Mar 8, 2019

Godot version:
3.1 RC1
86d6a72

OS/device including version:
Desktop platforms.

Issue description:
Since #26633, we no longer fallback to GLES2 by default.

There's a check in the OS::initialize code for default platforms to still enable the fallback for the "editor", but that's only for editor_hint, which is apparently not set for the Project Manager.

Actually, the PM sets the editor_hint to true in main.cpp, and then false in its own NOTIFICATION_ENTER_TREE. I think none of those happen early enough anyways, so the fallback fails. The editor might also fail falling back when opening a GLES3 project I guess (untested).

@akien-mga akien-mga added this to the 3.1 milestone Mar 8, 2019

@akien-mga akien-mga self-assigned this Mar 8, 2019

akien-mga added a commit to akien-mga/godot that referenced this issue Mar 9, 2019

Set editor hint early for Project Manager and Editor
We need it in setup() already before initializing the renderer,
as it's used to force fallback to GLES2 if GLES3 fails.

Fixes godotengine#26806.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.